Bugzilla – Attachment 13186 Details for
Bug 8842
Plack and tools/holidays.pl
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 8842 fix Plack scoping for holidays
Bug-8842-fix-Plack-scoping-for-holidays.patch (text/plain), 2.14 KB, created by
Paul Poulain
on 2012-11-02 09:02:48 UTC
(
hide
)
Description:
Bug 8842 fix Plack scoping for holidays
Filename:
MIME Type:
Creator:
Paul Poulain
Created:
2012-11-02 09:02:48 UTC
Size:
2.14 KB
patch
obsolete
>From ecb3f16473f4c57165fa42faab2eb1e2ce726523 Mon Sep 17 00:00:00 2001 >From: Paul Poulain <paul.poulain@biblibre.com> >Date: Fri, 2 Nov 2012 10:02:30 +0100 >Subject: [PATCH] Bug 8842 fix Plack scoping for holidays > >the internal sub add_holiday uses some variables that are defined in the main script, usual fix >--- > tools/newHolidays.pl | 18 +++++++++--------- > 1 file changed, 9 insertions(+), 9 deletions(-) > >diff --git a/tools/newHolidays.pl b/tools/newHolidays.pl >index ffe99a3..646276c 100755 >--- a/tools/newHolidays.pl >+++ b/tools/newHolidays.pl >@@ -15,19 +15,19 @@ use DateTime; > my $input = new CGI; > my $dbh = C4::Context->dbh(); > >-my $branchcode = $input->param('newBranchName'); >+our $branchcode = $input->param('newBranchName'); > my $originalbranchcode = $branchcode; >-my $weekday = $input->param('newWeekday'); >-my $day = $input->param('newDay'); >-my $month = $input->param('newMonth'); >-my $year = $input->param('newYear'); >+our $weekday = $input->param('newWeekday'); >+our $day = $input->param('newDay'); >+our $month = $input->param('newMonth'); >+our $year = $input->param('newYear'); > my $day1; > my $month1; > my $year1; > my $dateofrange = $input->param('dateofrange'); >-my $title = $input->param('newTitle'); >-my $description = $input->param('newDescription'); >-my $newoperation = $input->param('newOperation'); >+our $title = $input->param('newTitle'); >+our $description = $input->param('newDescription'); >+our $newoperation = $input->param('newOperation'); > my $allbranches = $input->param('allBranches'); > > my $calendardate = sprintf("%04d-%02d-%02d", $year, $month, $day); >@@ -57,7 +57,7 @@ if ($description) { > } > > # We make an array with holiday's days >-my @holiday_list; >+our @holiday_list; > if ($year1 && $month1 && $day1){ > my $first_dt = DateTime->new(year => $year, month => $month, day => $day); > my $end_dt = DateTime->new(year => $year1, month => $month1, day => $day1); >-- >1.7.9.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 8842
:
13186
|
13187
|
13199