Bugzilla – Attachment 131861 Details for
Bug 29486
_koha_marc_update_bib_ids no longer needed for GetMarcBiblio
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 29486: _koha_marc_update_bib_ids no longer needed for GetMarcBiblio
Bug-29486-kohamarcupdatebibids-no-longer-needed-fo.patch (text/plain), 2.54 KB, created by
Marcel de Rooy
on 2022-03-18 09:30:58 UTC
(
hide
)
Description:
Bug 29486: _koha_marc_update_bib_ids no longer needed for GetMarcBiblio
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2022-03-18 09:30:58 UTC
Size:
2.54 KB
patch
obsolete
>From e38659e5ade730e80f6e6b78aa9946c8789077c4 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 16 Nov 2021 09:13:30 +0100 >Subject: [PATCH] Bug 29486: _koha_marc_update_bib_ids no longer needed for > GetMarcBiblio >Content-Type: text/plain; charset=utf-8 > >This subroutine is ensuring that the biblionumber and biblioitemnumber >will be part of the MARC record. >We should not need that, unless there is something broken somewhere >else. > >This line has been added by the following commit: > commit 4e95e94727b09b33d2f6c597bdd218a59dcc3681 > Bug 6789: biblios with many items can result in broken search results link > >""" >To this end, it also moves the fix_biblio_ids portion of get_corrected_marc_record out of rebuild_zebra.pl, >and makes it a part of GetMarcBiblio (right before EmbedItemsInMarcBiblio, so the 952s still come last). fix_biblio_ids >is kept as a subroutine for the deletion portion of rebuild_zebra.pl, which still uses it. >""" > >But it does not explain why it's better to have it in GetMarcBiblio. >If we need it for the reindexation process, we shouldn't impact >GetMarcBiblio which is used from several different places. > >We might then consider adding the fix_biblio_ids call to >rebuild_zebra.pl, but I am failing to understand in which cases it could >be useful. > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > C4/Biblio.pm | 8 -------- > 1 file changed, 8 deletions(-) > >diff --git a/C4/Biblio.pm b/C4/Biblio.pm >index 48cdf473ec..c4de6b064d 100644 >--- a/C4/Biblio.pm >+++ b/C4/Biblio.pm >@@ -1217,14 +1217,8 @@ sub GetMarcBiblio { > return; > } > >- my $dbh = C4::Context->dbh; >- my $sth = $dbh->prepare("SELECT biblioitemnumber FROM biblioitems WHERE biblionumber=? "); >- $sth->execute($biblionumber); >- my $row = $sth->fetchrow_hashref; >- my $biblioitemnumber = $row->{'biblioitemnumber'}; > my $marcxml = GetXmlBiblio( $biblionumber ); > $marcxml = StripNonXmlChars( $marcxml ); >- my $frameworkcode = GetFrameworkCode($biblionumber); > MARC::File::XML->default_record_format( C4::Context->preference('marcflavour') ); > my $record = MARC::Record->new(); > >@@ -1236,8 +1230,6 @@ sub GetMarcBiblio { > if ($@) { warn " problem with :$biblionumber : $@ \n$marcxml"; } > return unless $record; > >- C4::Biblio::_koha_marc_update_bib_ids( $record, $frameworkcode, $biblionumber, >- $biblioitemnumber ); > C4::Biblio::EmbedItemsInMarcBiblio({ > marc_record => $record, > biblionumber => $biblionumber, >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 29486
:
127682
|
129608
|
129609
|
129610
|
131861
|
131862
|
131863
|
131865
|
131866
|
131867