Bugzilla – Attachment 131917 Details for
Bug 30009
Records with invalid MarcXML show notes tab 'Descriptions(1)' but tab is empty
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 30009: If no record set MARCNOTES undef, rather than empty array
Bug-30009-If-no-record-set-MARCNOTES-undef-rather-.patch (text/plain), 1.22 KB, created by
Nick Clemens (kidclamp)
on 2022-03-18 15:05:29 UTC
(
hide
)
Description:
Bug 30009: If no record set MARCNOTES undef, rather than empty array
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2022-03-18 15:05:29 UTC
Size:
1.22 KB
patch
obsolete
>From ae3ddd1f6f05bd49c66b05f9457d231fb67a5a8e Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Fri, 18 Mar 2022 15:03:30 +0000 >Subject: [PATCH] Bug 30009: If no record set MARCNOTES undef, rather than > empty array > >Currently we pass an empty array if there is no marc record - this >is read as 'true' by template toolkit, and the desciptions tab is loaded > >This patch just sets the variable as undef which is false > >To test: >1 - Find or create an invalid marc record >2 - View in staff client >3 - Note tab Descriptions(1) has no content >4 - Apply patch, reload >5 - No empty tab >--- > catalogue/detail.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/catalogue/detail.pl b/catalogue/detail.pl >index e11e8d1567..552e09d578 100755 >--- a/catalogue/detail.pl >+++ b/catalogue/detail.pl >@@ -459,7 +459,7 @@ $template->param( > ); > > $template->param( >- MARCNOTES => $marc_record ? $biblio->get_marc_notes({ marcflavour => $marcflavour }) : (), >+ MARCNOTES => $marc_record ? $biblio->get_marc_notes({ marcflavour => $marcflavour }) : undef, > itemdata_ccode => $itemfields{ccode}, > itemdata_enumchron => $itemfields{enumchron}, > itemdata_uri => $itemfields{uri}, >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 30009
:
131917
|
135008
|
135101