Attachment 131939 Details for Bug 30321 – Bug 23376: Fix template error on order receive page

Bug 23376: Fix template error on order receive page

0001-Bug-23376-Fix-template-error-on-order-receive-page.patch (text/plain), 2.07 KB, created by Emmi Takkinen on 2022-03-21 06:49:39 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Emmi Takkinen

Created: 2022-03-21 06:49:39 UTC

Size: 2.07 KB

patch

obsolete

>From f191db3b8f639b74d4edec6baa50217d259798d3 Mon Sep 17 00:00:00 2001
>From: Emmi Takkinen <emmi.takkinen@koha-suomi.fi>
>Date: Fri, 18 Mar 2022 09:18:47 +0200
>Subject: [PATCH] Bug 23376: Fix template error on order receive page
>
>Order receive page dies on error 500 if orders quantityreceived
>is more than 0. The error logs reads: "Template process failed: undef
>error - The method Koha::Item->count is not covered by tests!"
>In template orderreceive.tt we have "order.items.count" not
>"orders.items.count" as it should be.  Note! It seems that this error
>doesn't occur if template param edit is set as 1.
>
>To test:
>1. Find order with quantityreceived value more than 0.
>2. Try to receive this order.
>=> Error 500 page is displayed.
>3. Apply patch
>4. Repeat steps 1 and 2.
>=> Order receive page is displayed normally.
>
>Sponsored-by: Koha-Suomi Oy
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt
>index 0f84cb4384..fe2984a5c7 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt
>@@ -320,7 +320,7 @@
>                     <input type="text" inputmode="numeric" pattern="[0-9]*" size="20" name="quantityrec" id="quantity" value="[% order.quantityreceived | html %]" />
>                     <input id="origquantityrec" readonly="readonly" type="hidden" name="origquantityrec" value="[% order.quantityreceived | html %]" />
>                 [% ELSE %]
>-                    [% IF ( order.items.count ) %]
>+                    [% IF ( orders.items.count ) %]
>                         <input readonly="readonly" type="text" size="20" name="quantityrec" id="quantity" value="[% order.quantityreceived + 1 | html %]" />
>                     [% ELSE %]
>                         <input type="text" inputmode="numeric" pattern="[0-9]*" size="20" name="quantityrec" id="quantity" value="[% quantityreceived + 1 | html %]" />
>-- 
>2.25.1
>

Actions: View

Attachments on bug 30321: 131939