Bugzilla – Attachment 132009 Details for
Bug 29791
KohaOpacLanguage cookie should set the secure flag if using HTTPS
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 29791: KohaOpacLanguage cookie should set the secure flag if using https
Bug-29791-KohaOpacLanguage-cookie-should-set-the-s.patch (text/plain), 916 bytes, created by
Jonathan Druart
on 2022-03-22 11:16:27 UTC
(
hide
)
Description:
Bug 29791: KohaOpacLanguage cookie should set the secure flag if using https
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2022-03-22 11:16:27 UTC
Size:
916 bytes
patch
obsolete
>From faae19231ed22e8db2442ab3426e804cb4a63197 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Tue, 4 Jan 2022 10:24:18 -0500 >Subject: [PATCH] Bug 29791: KohaOpacLanguage cookie should set the secure flag > if using https > >To test, the headers should have value set-cookie: secure; >for the language cookie, when the site is using https. > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >--- > C4/Templates.pm | 1 + > 1 file changed, 1 insertion(+) > >diff --git a/C4/Templates.pm b/C4/Templates.pm >index 53e1dc50736..a3903ca26ae 100644 >--- a/C4/Templates.pm >+++ b/C4/Templates.pm >@@ -349,6 +349,7 @@ sub getlanguagecookie { > -value => $language, > -HttpOnly => 1, > -expires => '+3y' >+ -secure => ( C4::Context->https_enabled() ? 1 : 0 ), > ); > > return $cookie; >-- >2.25.1
<b>You cannot view the attachment while viewing its details because your browser does not support IFRAMEs. <a href="attachment.cgi?id=132009">View the attachment on a separate page</a>.</b>
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 29791
:
129004
|
129223
|
129224
| 132009 |
132010