Bugzilla – Attachment 132017 Details for
Bug 30266
Holds marked waiting with a holdingbranch that does not match can cause loss of pickup locations
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 30266: Hide pickup location input on waiting hold
Bug-30266-Hide-pickup-location-input-on-waiting-ho.patch (text/plain), 3.49 KB, created by
Jonathan Druart
on 2022-03-22 12:41:42 UTC
(
hide
)
Description:
Bug 30266: Hide pickup location input on waiting hold
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2022-03-22 12:41:42 UTC
Size:
3.49 KB
patch
obsolete
>From 243a03786ce094b428330cc6828923f8fc4abcba Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Thu, 10 Mar 2022 12:23:42 +0000 >Subject: [PATCH] Bug 30266: Hide pickup location input on waiting hold > >This patch updates the holds table to always insert a hidden input when a hold is 'found' >and covers the case where the hold is 'found' but doesn't match known statuses > >To test: > 1 - Place two holds on a record for two different patrons, with different pickup locations > 2 - Check in one item at expected branch to set waiting > 3 - Then either: > - Use batch modification or item editor to change the holding branch for the item > - Sign in to a different branch and manually transfer the item back to it's home location > 4 - View the holds for the record > 5 - Note the 'Pickup library' column is blank for that hold > 6 - Change pickup location for other hold and press 'Update holds' > 7 - Note the waiting hold is still blank, and now second hold has no pickup location > 8 - Check the DB and note the first hold has had the pickup location changed > 8 - Apply patch > 9 - Delete holds and repeat 1-4 >10 - Note the waiting hold now displays: > Hold expected at {Branch}, please checkin to verify status >11 - Change location for second hold and update holds >12 - COnfirm location chanegd correctly and first hold unaffected > >Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >--- > koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc >index fddaad03e33..b3951572cae 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc >@@ -119,12 +119,15 @@ > </td> > <td> > [%- IF ( hold.found ) -%] >+ <input type="hidden" name="pickup" value="[% hold.wbrcode | html %]" /> > [%- IF ( hold.atdestination ) -%] >- Item waiting at <strong> [% hold.wbrname | html %]</strong>[% IF hold.desk_name %], [% hold.desk_name | html %],[% END %] <input type="hidden" name="pickup" value="[% hold.wbrcode | html %]" /> since [% hold.waiting_date | $KohaDates %] >+ Item waiting at <strong> [% hold.wbrname | html %]</strong>[% IF hold.desk_name %], [% hold.desk_name | html %],[% END %] since [% hold.waiting_date | $KohaDates %] > [%- ELSIF (hold.intransit) -%] >- Item being transferred to <strong> [% hold.wbrname | html %]</strong> <input type="hidden" name="pickup" value="[% hold.wbrcode | html %]" /> >+ Item being transferred to <strong> [% hold.wbrname | html %]</strong> > [%- ELSIF (hold.inprocessing) -%] >- Item being processed at <strong> [% hold.wbrname | html %]</strong> <input type="hidden" name="pickup" value="[% hold.wbrcode | html %]" /> >+ Item being processed at <strong> [% hold.wbrname | html %]</strong> >+ [%- ELSE -%] >+ Hold expected at <strong>[% hold.wbrname | html %]</strong>, please checkin to verify status > [%- END -%] > [%- ELSE -%] > [%- IF Koha.Preference('IndependentBranches') && Branches.all().size == 1 -%] >-- >2.25.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 30266
:
131553
|
131579
| 132017