Attachment 132039 Details for Bug 30250 – Bug 30250: Use ApplyFrameworkDefaults when importing a record

[patch] Bug 30250: Use ApplyFrameworkDefaults when importing a record

Bug-30250-Use-ApplyFrameworkDefaults-when-importin.patch (text/plain), 6.70 KB, created by Aleisha Amohia on 2022-03-22 21:45:41 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Aleisha Amohia

Created: 2022-03-22 21:45:41 UTC

Size: 6.70 KB

patch

obsolete

>From ab9a2b0e5fb35a61da0dab5d45412227ff20ce55 Mon Sep 17 00:00:00 2001
>From: Aleisha Amohia <aleishaamohia@hotmail.com>
>Date: Tue, 22 Mar 2022 21:26:35 +0000
>Subject: [PATCH] Bug 30250: Use ApplyFrameworkDefaults when importing a record
>
>This patch adds the case of importing a record to the
>ApplyFrameworkDefaults options.
>
>To test:
>1. Update database
>2. Confirm the ApplyFrameworkDefaults system preference now has the
>'when importing a record' option. Do not select it.
>3. Go to Cataloguing. Import a record from z39.50, or import to an
>existing record.
>4. Confirm framework defaults are not applied.
>5. Go back to the system preference and check the 'when importing a
>record' option.
>6. Repeat step 3. This time framework defaults should be applied. Only
>fields that are empty in the imported record will be replaced by
>framework defaults.
>
>Sponsored-by: Catalyst IT
>---
> authorities/authorities.pl                                          | 3 ++-
> cataloguing/addbiblio.pl                                            | 6 ++++--
> .../atomicupdate/bug_30250_-_add_ApplyFrameworkDefaults_syspref.pl  | 2 +-
> installer/data/mysql/mandatory/sysprefs.sql                         | 2 +-
> .../prog/en/modules/admin/preferences/cataloguing.pref              | 1 +
> 5 files changed, 9 insertions(+), 5 deletions(-)
>
>diff --git a/authorities/authorities.pl b/authorities/authorities.pl
>index 5604f794a3..534473f4a5 100755
>--- a/authorities/authorities.pl
>+++ b/authorities/authorities.pl
>@@ -134,7 +134,8 @@ sub create_input {
>     my $applydefaults = C4::Context->preference('ApplyFrameworkDefaults');
>     if ( $value eq '' && (
>         ( $applydefaults =~ /new/ && !$cgi->param('authid') ) ||
>-        ( $applydefaults =~ /duplicate/ && $cgi->param('op') eq 'duplicate' )
>+        ( $applydefaults =~ /duplicate/ && $cgi->param('op') eq 'duplicate' ) ||
>+        ( $applydefaults =~ /imported/ && $cgi->param('breedingid') )
>     ) ) {
>         $value = $tagslib->{$tag}->{$subfield}->{defaultvalue};
>         if (!defined $value) {
>diff --git a/cataloguing/addbiblio.pl b/cataloguing/addbiblio.pl
>index 95fadb676f..cfbbb8bc59 100755
>--- a/cataloguing/addbiblio.pl
>+++ b/cataloguing/addbiblio.pl
>@@ -285,19 +285,21 @@ sub GetMandatoryFieldZ3950 {
> 
> sub create_input {
>     my ( $tag, $subfield, $value, $index_tag, $rec, $authorised_values_sth,$cgi ) = @_;
>-    
>+
>     my $index_subfield = CreateKey(); # create a specifique key for each subfield
> 
>     # Apply optional framework default value when it is a new record,
>     # or when editing as new (duplicating a record),
>     # or when changing a record's framework,
>+    # or when importing a record,
>     # based on the ApplyFrameworkDefaults setting.
>     # Substitute date parts, user name
>     my $applydefaults = C4::Context->preference('ApplyFrameworkDefaults');
>     if ( $value eq '' && (
>         ( $applydefaults =~ /new/ && !$cgi->param('biblionumber') ) ||
>         ( $applydefaults =~ /duplicate/ && $cgi->param('op') eq 'duplicate' ) ||
>-        ( $applydefaults =~ /changed/ && $cgi->param('changed_framework') )
>+        ( $applydefaults =~ /changed/ && $cgi->param('changed_framework') ) ||
>+        ( $applydefaults =~ /imported/ && $cgi->param('breedingid') )
>     ) ) {
>         $value = $tagslib->{$tag}->{$subfield}->{defaultvalue} // q{};
> 
>diff --git a/installer/data/mysql/atomicupdate/bug_30250_-_add_ApplyFrameworkDefaults_syspref.pl b/installer/data/mysql/atomicupdate/bug_30250_-_add_ApplyFrameworkDefaults_syspref.pl
>index 50f1c3b310..39b7c8ccb5 100644
>--- a/installer/data/mysql/atomicupdate/bug_30250_-_add_ApplyFrameworkDefaults_syspref.pl
>+++ b/installer/data/mysql/atomicupdate/bug_30250_-_add_ApplyFrameworkDefaults_syspref.pl
>@@ -7,6 +7,6 @@ return {
>         my ($args) = @_;
>         my ($dbh, $out) = @$args{qw(dbh out)};
> 
>-        $dbh->do(q{INSERT IGNORE INTO systempreferences (variable,value,options,explanation,type) VALUES ('ApplyFrameworkDefaults', 'new', "new|duplicate|changed", "Configure when to apply framework default values - when cataloguing a new record, or when editing a record as new (duplicating), or when changing framework", 'multiple') });
>+        $dbh->do(q{INSERT IGNORE INTO systempreferences (variable,value,options,explanation,type) VALUES ('ApplyFrameworkDefaults', 'new', "new|duplicate|changed|imported", "Configure when to apply framework default values - when cataloguing a new record, or when editing a record as new (duplicating), or when changing framework, or when importing a record", 'multiple') });
>     },
> };
>diff --git a/installer/data/mysql/mandatory/sysprefs.sql b/installer/data/mysql/mandatory/sysprefs.sql
>index 2989c8eb3b..fb532a8809 100644
>--- a/installer/data/mysql/mandatory/sysprefs.sql
>+++ b/installer/data/mysql/mandatory/sysprefs.sql
>@@ -54,7 +54,7 @@ INSERT INTO systempreferences ( `variable`, `value`, `options`, `explanation`, `
> ('AmazonLocale','US','US|CA|DE|FR|IN|JP|UK','Use to set the Locale of your Amazon.com Web Services','Choice'),
> ('AnonSuggestions','0',NULL,'Set to enable Anonymous suggestions to AnonymousPatron borrowernumber','YesNo'),
> ('AnonymousPatron','0',NULL,'Set the identifier (borrowernumber) of the anonymous patron. Used for suggestion and checkout history privacy',''),
>-('ApplyFrameworkDefaults', 'new', 'new|duplicate|changed', 'Configure when to apply framework default values - when cataloguing a new record, or when editing a record as new (duplicating), or when changing framework', 'multiple'),
>+('ApplyFrameworkDefaults', 'new', 'new|duplicate|changed|imported', 'Configure when to apply framework default values - when cataloguing a new record, or when editing a record as new (duplicating), or when changing framework, or when importing a record', 'multiple'),
> ('ArticleRequests', '0', NULL, 'Enables the article request feature', 'YesNo'),
> ('ArticleRequestsOpacHostRedirection', '0', NULL, 'Enables redirection from child to host when requesting articles on the Opac', 'YesNo'),
> ('ArticleRequestsLinkControl', 'calc', 'always|calc', 'Control display of article request link on search results', 'Choice'),
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/cataloguing.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/cataloguing.pref
>index 3207b1e149..96fe1a2bfc 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/cataloguing.pref
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/cataloguing.pref
>@@ -172,6 +172,7 @@ Cataloging:
>                 new: "when cataloguing new records"
>                 duplicate: "when editing records as new (duplicating)"
>                 changed: "when changing the framework while editing the existing record"
>+                imported: "when importing a record"
>     Display:
>         -
>             - 'Separate main entry and subdivisions with '
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 30250: 131505 | 131506 | 132039 | 132040 | 140238 | 140239 | 140240 | 140241 | 141961 | 141962 | 141963 | 141964 | 141965 | 142024 | 142025 | 142026 | 142027 | 142777 | 142778 | 142779 | 142780