Attachment 132123 Details for Bug 30194 – Bug 30194: (26351 follow-up) Silence useless warning

[patch] Bug 30194: (26351 follow-up) Silence useless warning

Bug-30194-26351-follow-up-Silence-useless-warning.patch (text/plain), 1.55 KB, created by Martin Renvoize (ashimema) on 2022-03-24 11:35:32 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2022-03-24 11:35:32 UTC

Size: 1.55 KB

patch

obsolete

>From 3c0a3a95de8f9850a9970d99f48dd0cde9d51d48 Mon Sep 17 00:00:00 2001
>From: Tomas Cohen Arazi <tomascohen@theke.io>
>Date: Tue, 8 Mar 2022 16:08:26 -0300
>Subject: [PATCH] Bug 30194: (26351 follow-up) Silence useless warning
>
>Every place in which Koha::Plugin::Test is loaded, and a patron is
>updated, this hook needs to be silenced.
>
>To reproduce:
>1. Run:
>   $ kshell
>  k$ prove t/db_dependent/Koha/REST/Plugin/PluginRoutes.t
>=> FAIL: There's a warn about patron_barcode_transform
>2. Apply this patch
>3. Repeat 1
>=> SUCCESS: Tests pass!
>4. Sign off :-D
>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Signed-off-by: Mason James <mtj@kohaaloha.com>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> t/db_dependent/Koha/REST/Plugin/PluginRoutes.t | 4 ++++
> 1 file changed, 4 insertions(+)
>
>diff --git a/t/db_dependent/Koha/REST/Plugin/PluginRoutes.t b/t/db_dependent/Koha/REST/Plugin/PluginRoutes.t
>index 1bd91c9015..66746508ed 100755
>--- a/t/db_dependent/Koha/REST/Plugin/PluginRoutes.t
>+++ b/t/db_dependent/Koha/REST/Plugin/PluginRoutes.t
>@@ -138,6 +138,10 @@ subtest 'Permissions and access to plugin routes tests' => sub {
>     # enable BASIC auth
>     t::lib::Mocks::mock_preference( 'RESTBasicAuth', 1 );
> 
>+    # Silence warnings from unrelated plugins feature
>+    my $plugin_mock = Test::MockModule->new('Koha::Plugin::Test');
>+    $plugin_mock->mock( 'patron_barcode_transform', undef );
>+
>     # remove any existing plugins that might interfere
>     Koha::Plugins::Methods->search->delete;
>     my $plugins = Koha::Plugins->new;
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 30194: 131374 | 131486 | 131487 | 131488 | 131497 | 131498 | 131499 | 131500 | 131501 | 131502 | 131547 | 131548 | 131549 | 131550 | 131551 | 131552 | 132069 | 132070 | 132071 | 132072 | 132073 | 132097 | 132098 | 132099 | 132100 | 132102 | 132112 | 132116 | 132118 | 132119 | 132120 | 132121 | 132122 | 132123 | 132124 | 132125 | 132126 | 132151 | 132152 | 132252 | 132253 | 132254 | 132334 | 132335 | 132336 | 132337 | 132338 | 132339 | 132340 | 132442 | 132449