Bugzilla – Attachment 132215 Details for
Bug 28294
C4::Circulation::updateWrongTransfer should be moved into Koha::
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 28294: Remove use of updateWrongTransfer
Bug-28294-Remove-use-of-updateWrongTransfer.patch (text/plain), 1.58 KB, created by
Marcel de Rooy
on 2022-03-25 09:41:12 UTC
(
hide
)
Description:
Bug 28294: Remove use of updateWrongTransfer
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2022-03-25 09:41:12 UTC
Size:
1.58 KB
patch
obsolete
>From 35a9199eb067bb8ef34fe53188c0f6c20771e8e2 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Tue, 18 May 2021 08:31:00 +0100 >Subject: [PATCH] Bug 28294: Remove use of updateWrongTransfer >Content-Type: text/plain; charset=utf-8 > >This patch removes the last remaining use of updateWrongTransfer. > >Test plan >1/ git grep updateWrongTransfer to confirm there are no more uses of the >method. >2/ Confirm an incorrect transfer still behaves as expected at >circulation returns. >--- > circ/returns.pl | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > >diff --git a/circ/returns.pl b/circ/returns.pl >index f98907187a..f794ea9429 100755 >--- a/circ/returns.pl >+++ b/circ/returns.pl >@@ -35,7 +35,7 @@ use CGI qw ( -utf8 ); > use DateTime; > > use C4::Auth qw( get_template_and_user get_session haspermission ); >-use C4::Circulation qw( barcodedecode GetBranchItemRule AddReturn updateWrongTransfer LostItem ); >+use C4::Circulation qw( barcodedecode GetBranchItemRule AddReturn LostItem ); > use C4::Context; > use C4::Items qw( ModItemTransfer ); > use C4::Members::Messaging; >@@ -443,7 +443,8 @@ if ( $messages->{'WrongTransfer'} and not $messages->{'WasTransfered'}) { > ); > > # Update the transfer to reflect the new item holdingbranch >- my $new_transfer = updateWrongTransfer($messages->{'WrongTransferItem'},$messages->{'WrongTransfer'}, $userenv_branch); >+ my $transfer = Koha::Items->find($messages->{'WrongTransferItem'})->get_transfer; >+ my $new_transfer = $transfer->remedy(); > $template->param( > NewTransfer => $new_transfer->id > ); >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 28294
:
120637
|
121062
|
121063
|
121064
|
121077
|
121078
|
121079
|
121095
|
121096
|
121097
|
121714
|
121715
|
121716
|
130082
|
130083
|
130084
|
130085
|
130086
|
130087
|
132212
|
132213
|
132214
|
132215
|
132216
|
132217
|
160516
|
160517
|
160518
|
160519
|
160520
|
160521
|
160536
|
160692
|
168281
|
172778
|
172781
|
173856
|
174805