Bugzilla – Attachment 132293 Details for
Bug 29957
Cookies not removed after logout
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 29957: Let check_api_auth return created cookie
Bug-29957-Let-checkapiauth-return-created-cookie.patch (text/plain), 1.36 KB, created by
Martin Renvoize (ashimema)
on 2022-03-28 07:54:06 UTC
(
hide
)
Description:
Bug 29957: Let check_api_auth return created cookie
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2022-03-28 07:54:06 UTC
Size:
1.36 KB
patch
obsolete
>From f55c2975ded78a14cdb484554be72654d435faf2 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Thu, 17 Mar 2022 09:21:46 +0000 >Subject: [PATCH] Bug 29957: Let check_api_auth return created cookie > >The cookie created on L1496 is useless, since it is not returned. >We could either remove the cookie creation (unchanged behavior). >But since check_api_auth is expected to return a cookie when it is ok, >I opt for returning the cookie here (corrected behavior). > >Test plan: >Logout in staff. >Check on staff: /cgi-bin/koha/svc/localization?id=1 >You should have a 400 response. >Login with staff credentials (incl. manage_itemtypes) >Revisit same URL. >You should see a JSON response. >Check if you can hit other staff pages. > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> > >Signed-off-by: Nick Clemens <nick@bywatersolutions.com> >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > C4/Auth.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/C4/Auth.pm b/C4/Auth.pm >index 6cbb9b8c79..3a49cb1e6a 100644 >--- a/C4/Auth.pm >+++ b/C4/Auth.pm >@@ -1503,7 +1503,7 @@ sub check_api_auth { > -HttpOnly => 1, > -secure => ( C4::Context->https_enabled() ? 1 : 0 ), > ); >- return ( $return, undef, $session ); >+ return ( $return, $cookie, $session ); # return == 'ok' here > > } else { > >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 29957
:
129871
|
129872
|
130005
|
130006
|
131428
|
131750
|
131751
|
131752
|
131807
|
131808
|
131809
|
131810
|
131824
|
131825
|
131826
|
131827
|
131828
|
131840
|
131841
|
131842
|
131843
|
131856
|
132045
|
132046
|
132047
|
132105
|
132106
|
132107
|
132108
|
132109
|
132110
|
132111
|
132115
|
132210
|
132211
|
132231
|
132232
|
132233
|
132234
|
132235
|
132236
|
132237
|
132238
|
132239
|
132288
|
132289
|
132290
|
132291
|
132292
| 132293 |
132294
|
132295
|
132296