Bugzilla – Attachment 132325 Details for
Bug 30377
Fix two CGI::param called in list context-warnings
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 30377: Fix two CGI::param called in list context-warnings
Bug-30377-Fix-two-CGIparam-called-in-list-context-.patch (text/plain), 1.64 KB, created by
Nick Clemens (kidclamp)
on 2022-03-28 12:48:50 UTC
(
hide
)
Description:
Bug 30377: Fix two CGI::param called in list context-warnings
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2022-03-28 12:48:50 UTC
Size:
1.64 KB
patch
obsolete
>From 2b7d62d9fd8a04e15b4e9dc9c3247c4654e56c36 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Mon, 28 Mar 2022 12:07:43 +0000 >Subject: [PATCH] Bug 30377: Fix two CGI::param called in list context-warnings > >Trivial fix. > >Test plan: >Delete two lines from opac search history. >Verify results. Check plack-opac-error.log. > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> > >Signed-off-by: Nick Clemens <nick@bywatersolutions.com> >--- > opac/opac-search-history.pl | 2 +- > serials/claims.pl | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > >diff --git a/opac/opac-search-history.pl b/opac/opac-search-history.pl >index 019fdc6b69..8ef23062e7 100755 >--- a/opac/opac-search-history.pl >+++ b/opac/opac-search-history.pl >@@ -102,7 +102,7 @@ unless ( $loggedinuser ) { > C4::Search::History::delete( > { > userid => $loggedinuser, >- id => [ $cgi->param('id') ], >+ id => [ @id ], > } > ); > } else { >diff --git a/serials/claims.pl b/serials/claims.pl >index a16d840efe..5b5479f749 100755 >--- a/serials/claims.pl >+++ b/serials/claims.pl >@@ -59,7 +59,7 @@ my @serialnums=$input->multi_param('serialid'); > if (@serialnums) { # i.e. they have been flagged to generate claims > my $err; > eval { >- $err = SendAlerts('claimissues',\@serialnums,$input->param("letter_code")); >+ $err = SendAlerts( 'claimissues', \@serialnums, scalar $input->param("letter_code") ); > if ( not ref $err or not exists $err->{error} ) { > C4::Serials::updateClaim( \@serialnums ); > } >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 30377
:
132322
| 132325