Attachment 132329 Details for Bug 25375 – Bug 25375: (QA follow-up) Count available items rather than iterating

[patch] Bug 25375: (QA follow-up) Count available items rather than iterating

Bug-25375-QA-follow-up-Count-available-items-rathe.patch (text/plain), 1.86 KB, created by Nick Clemens (kidclamp) on 2022-03-28 13:42:02 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2022-03-28 13:42:02 UTC

Size: 1.86 KB

patch

obsolete

>From 7e329a95d3a7ef4f6ece5dd5245bce9eb516524b Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Fri, 11 Sep 2020 15:23:02 +0000
>Subject: [PATCH] Bug 25375: (QA follow-up) Count available items rather than
> iterating
>
>Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
>---
> Koha/SearchEngine/Elasticsearch.pm | 25 ++++++++++---------------
> 1 file changed, 10 insertions(+), 15 deletions(-)
>
>diff --git a/Koha/SearchEngine/Elasticsearch.pm b/Koha/SearchEngine/Elasticsearch.pm
>index 51c49a5aed..714620cc7e 100644
>--- a/Koha/SearchEngine/Elasticsearch.pm
>+++ b/Koha/SearchEngine/Elasticsearch.pm
>@@ -777,21 +777,16 @@ sub marc_records_to_documents {
>             my ($tag, $code) = C4::Biblio::GetMarcFromKohaField('biblio.biblionumber');
>             my $field = $record->field($tag);
>             my $biblionumber = $field->is_control_field ? $field->data : $field->subfield($code);
>-            my $biblio = Koha::Biblios->find($biblionumber);
>-            my $items = $biblio->items;
>-            my $available = 0;
>-            while (my $item = $items->next) {
>-                next if $item->onloan;
>-                next if $item->notforloan;
>-                next if $item->withdrawn;
>-                next if $item->itemlost;
>-                next if $item->damaged;
>-
>-                $available = 1;
>-                last;
>-            }
>-
>-            $record_document->{available} = $available ? \1 : \0;
>+            my $avail_items = Koha::Items->search({
>+                biblionumber => $biblionumber,
>+                onloan       => undef,
>+                notforloan   => 0,
>+                withdrawn    => 0,
>+                itemlost     => 0,
>+                damaged      => 0
>+            })->count;
>+
>+            $record_document->{available} = $avail_items ? \1 : \0;
>         }
> 
>         push @record_documents, $record_document;
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 25375: 104356 | 109647 | 109659 | 109660 | 109951 | 109952 | 109953 | 109954 | 131310 | 131311 | 131312 | 131313 | 132327 | 132328 | 132329 | 132330 | 138800 | 138802 | 138803 | 140053 | 140054 | 140055 | 140056 | 140057 | 140572 | 140899 | 140900 | 140979