Attachment 132364 Details for Bug 27113 – Bug 27113: Rebase and correct autocomplete appearance

[patch] Bug 27113: Rebase and correct autocomplete appearance

Bug-27113-Rebase-and-correct-autocomplete-appearan.patch (text/plain), 2.78 KB, created by The Minh Luong on 2022-03-28 19:53:55 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: The Minh Luong

Created: 2022-03-28 19:53:55 UTC

Size: 2.78 KB

patch

obsolete

>From c2afbd8ab0c80302575a9f2980bc85bac5e2901b Mon Sep 17 00:00:00 2001
>From: The Minh Luong <theminh@inlibro.com>
>Date: Tue, 1 Mar 2022 14:35:47 -0500
>Subject: [PATCH] Bug 27113: Rebase and correct autocomplete appearance
>
>Rebase of previous patches and correct the buggy behavior (See "GIF showing buggy behavior attachment")
>
>Test plan:
>1- Search for an item. Notice that the autocomplete functionnality is not available. (See "Result" attachment)
>2- Make sure that you are using Elasticsearch as your searching engine. (Preference->SearchEngine->ElasticSearch)
>3- Apply the patch.
>4- Run ./installer/data/mysql/updatedatabase.pl
>5- Looks for the following preferences :
>   - IntranetAutocompleteElasticSearch
>   - OPACAutocompleteElasticSearch
>6- Set their value to show.
>7- Rebuild the OPAC and staff client CSS (This step is important because the autocomplete CSS is moved to the main SCSS file):
>   Instructions here: https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client
>8- Search for an item and notice that the autocomplete functionnality is now available.
>9- In the staff interface, go in "Search the catalog".
>10- Notice that the buggy behavior is now fixed.
>---
> koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss                | 3 +--
> .../bootstrap/js/opac-elasticsearch/opac-autocomplete.js       | 1 +
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss b/koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss
>index 158ad28933..0a5789a8d8 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss
>+++ b/koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss
>@@ -2858,7 +2858,6 @@ $star-selected: #EDB867;
> .autocomplete {
>     /*the container must be positioned relative:*/
>     position: relative;
>-    display: inline-block;
>     width: 100%;
> }
> 
>@@ -2867,7 +2866,7 @@ $star-selected: #EDB867;
>     border: 1px solid #d4d4d4;
>     border-bottom: none;
>     border-top: none;
>-    z-index: 99;
>+    z-index: 9999;
> 
>     div {
>         padding: 10px;
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/js/opac-elasticsearch/opac-autocomplete.js b/koha-tmpl/opac-tmpl/bootstrap/js/opac-elasticsearch/opac-autocomplete.js
>index eaa8ece900..01d6332caa 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/js/opac-elasticsearch/opac-autocomplete.js
>+++ b/koha-tmpl/opac-tmpl/bootstrap/js/opac-elasticsearch/opac-autocomplete.js
>@@ -51,6 +51,7 @@ function autocomplete(inp, nb, left, right) {
>     /* create new div with position relative for class .autocomplete with absolute */
>     var div_relative = document.createElement('div');
>     $(div_relative).addClass( "autocomplete" );
>+    $(div_relative).css("display", "inline-block");
>     div_relative.append(inp);
>     /* input doesn't have an elem after, add it to parent */
>     if (next_elem_inp === null){
>-- 
>2.25.1

Actions: View | Diff | Splinter Review

Attachments on bug 27113: 114168 | 114169 | 114945 | 115117 | 116293 | 119979 | 120028 | 120029 | 120084 | 120088 | 120109 | 120140 | 120141 | 120806 | 121497 | 121498 | 121555 | 121556 | 121557 | 121558 | 131207 | 131208 | 131209 | 131210 | 131211 | 132360 | 132361 | 132362 | 132363 | 132364 | 132808 | 132945 | 132946 | 133042 | 133045 | 133407 | 133409 | 133410 | 136312 | 136456 | 136457 | 136464 | 136465 | 136653 | 136657 | 136658 | 136659 | 136660 | 137436 | 137437 | 137438 | 137439 | 137780 | 137781 | 137782 | 137783 | 139624 | 141466 | 145167 | 146015 | 159769 | 159770 | 159771 | 159772 | 159773 | 159774 | 159775 | 160134 | 160135 | 160136 | 160137 | 160138 | 160139 | 160140 | 160141 | 160142 | 161076 | 161077 | 163826 | 165895 | 165896 | 165897 | 165898 | 165899 | 165900 | 165901 | 165902 | 165903 | 165904 | 165913 | 165922