Attachment 132373 Details for Bug 26346 – Bug 26346: (follow-up) Fixing for QA tool

[patch] Bug 26346: (follow-up) Fixing for QA tool

Bug-26346-follow-up-Fixing-for-QA-tool.patch (text/plain), 2.35 KB, created by Alex Buckley on 2022-03-28 22:12:08 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Alex Buckley

Created: 2022-03-28 22:12:08 UTC

Size: 2.35 KB

patch

obsolete

>From 44f551acc8d25e8ff828dd9a2cb5c02ba71a16ad Mon Sep 17 00:00:00 2001
>From: Alex Buckley <alexbuckley@catalyst.net.nz>
>Date: Mon, 28 Mar 2022 22:07:07 +0000
>Subject: [PATCH] Bug 26346: (follow-up) Fixing for QA tool
>
>Adding is_boolean to virtualshelves.public and
>virtualshelves.allow_change_from_staff in Virtualshelve.pm DBIC schema file.
>
>Fixing typo in Virtualshelves.t
>
>Sponsored-by: Catalyst IT, New Zealand
>---
> Koha/Schema/Result/Virtualshelve.pm | 8 ++++++++
> t/db_dependent/Virtualshelves.t     | 2 +-
> 2 files changed, 9 insertions(+), 1 deletion(-)
>
>diff --git a/Koha/Schema/Result/Virtualshelve.pm b/Koha/Schema/Result/Virtualshelve.pm
>index 06bc299c62..ef240f6751 100644
>--- a/Koha/Schema/Result/Virtualshelve.pm
>+++ b/Koha/Schema/Result/Virtualshelve.pm
>@@ -217,5 +217,13 @@ sub koha_objects_class {
>     'Koha::Virtualshelves';
> }
> 
>+__PACKAGE__->add_columns(
>+    '+public' => { is_boolean => 1 },
>+);
>+
>+__PACKAGE__->add_columns(
>+    '+allow_change_from_staff' => { is_boolean => 1 },
>+);
>+
> # You can replace this text with custom code or comments, and it will be preserved on regeneration
> 1;
>diff --git a/t/db_dependent/Virtualshelves.t b/t/db_dependent/Virtualshelves.t
>index 7d33bfc0de..c23db964ed 100755
>--- a/t/db_dependent/Virtualshelves.t
>+++ b/t/db_dependent/Virtualshelves.t
>@@ -327,7 +327,7 @@ subtest 'Shelf permissions' => sub {
>     is( $public_shelf->can_be_deleted( $patron3->{borrowernumber} ), 0, 'Public list should not be deleted by someone with no special permissions' );
>     is( $public_shelf->can_be_deleted( $patron4->{borrowernumber} ), 0, 'Public list should not be deleted by someone with the edit_public_lists sub-permission checked' );
> 
>-    is( $public_shelf->can_be_managed( $patron1->{borrowernumber} ), 1, 'The owner should be able to manage thier list' );
>+    is( $public_shelf->can_be_managed( $patron1->{borrowernumber} ), 1, 'The owner should be able to manage their list' );
>     is( $public_shelf->can_be_managed( $patron2->{borrowernumber} ), 0, 'Public list should not be managed by another staff member' );
>     is( $public_shelf->can_be_managed( $patron3->{borrowernumber} ), 0, 'Public list should not be managed by someone with no special permissions' );
>     is( $public_shelf->can_be_managed( $patron4->{borrowernumber} ), 1, 'Public list should be managed by someone with the edit_public_lists sub-permission checked' );
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 26346: 119686 | 120663 | 120664 | 120665 | 120909 | 120910 | 120953 | 120954 | 121511 | 121512 | 122033 | 122034 | 122533 | 122535 | 122536 | 122537 | 122538 | 122539 | 122540 | 122685 | 122686 | 122687 | 122688 | 122689 | 122691 | 124010 | 124011 | 125436 | 125472 | 125914 | 125915 | 125916 | 125917 | 127556 | 127557 | 127558 | 127559 | 127560 | 128017 | 128018 | 128019 | 128020 | 128021 | 128022 | 128023 | 128383 | 128384 | 128385 | 131699 | 131700 | 131757 | 131764 | 132373 | 132475 | 132476 | 132477 | 132478 | 132479 | 132751 | 132752 | 132753 | 132754 | 132755