Bugzilla – Attachment 132449 Details for
Bug 30194
Update required JSON::Validator version
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 30194: (follow-up) Fix xt/api.t
Bug-30194-follow-up-Fix-xtapit.patch (text/plain), 1.17 KB, created by
Tomás Cohen Arazi (tcohen)
on 2022-03-29 15:13:44 UTC
(
hide
)
Description:
Bug 30194: (follow-up) Fix xt/api.t
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2022-03-29 15:13:44 UTC
Size:
1.17 KB
patch
obsolete
>From b3eb7b2677753b701f16a0ea8d6eefe7c10f04a8 Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@theke.io> >Date: Tue, 29 Mar 2022 17:12:39 +0200 >Subject: [PATCH] Bug 30194: (follow-up) Fix xt/api.t > >The query object can have an arbitrary structure, and thus it doesn't >make sense to check for the additionalProperties presence. also, it is >not allowed by OpenAPIv2 :-D > >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >--- > xt/api.t | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > >diff --git a/xt/api.t b/xt/api.t >index 3d33a669bf..1dd206f498 100755 >--- a/xt/api.t >+++ b/xt/api.t >@@ -39,7 +39,8 @@ foreach my $route ( keys %{$paths} ) { > && $parameter->{schema}->{type} eq 'object' ) { > > # it is an object type definition >- if ( not exists $parameter->{schema}->{additionalProperties} ) { >+ if ( $parameter->{name} ne 'query' # our query parameter is under-specified >+ and not exists $parameter->{schema}->{additionalProperties} ) { > push @missing_additionalProperties, > { type => 'parameter', > route => $route, >-- >2.35.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 30194
:
131374
|
131486
|
131487
|
131488
|
131497
|
131498
|
131499
|
131500
|
131501
|
131502
|
131547
|
131548
|
131549
|
131550
|
131551
|
131552
|
132069
|
132070
|
132071
|
132072
|
132073
|
132097
|
132098
|
132099
|
132100
|
132102
|
132112
|
132116
|
132118
|
132119
|
132120
|
132121
|
132122
|
132123
|
132124
|
132125
|
132126
|
132151
|
132152
|
132252
|
132253
|
132254
|
132334
|
132335
|
132336
|
132337
|
132338
|
132339
|
132340
|
132442
| 132449