Bugzilla – Attachment 132548 Details for
Bug 26669
Last Run column not updated when report is run publicly (via CoverFlow or elsewhere)
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 26669: Avoid a warn in update_sql
Bug-26669-Avoid-a-warn-in-updatesql.patch (text/plain), 1.26 KB, created by
Séverine Queune
on 2022-03-30 09:44:45 UTC
(
hide
)
Description:
Bug 26669: Avoid a warn in update_sql
Filename:
MIME Type:
Creator:
Séverine Queune
Created:
2022-03-30 09:44:45 UTC
Size:
1.26 KB
patch
obsolete
>From ba7e8bd2d2b40625e1dcd23706ff39ab29da59f2 Mon Sep 17 00:00:00 2001 >From: Fridolin Somers <fridolin.somers@biblibre.com> >Date: Thu, 14 Jan 2021 16:41:07 +0100 >Subject: [PATCH] Bug 26669: Avoid a warn in update_sql >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >In C4/Reports/Guided.pm update_sql() called by test suite return warn : >Use of uninitialized value $sql in substitution (s///) > >Test plan : >Run prove t/db_dependent/Reports/Guided.t and see warning disapearing >(whouchhhh) > >Signed-off-by: Séverine Queune <severine.queune@bulac.fr> > >Signed-off-by: Séverine Queune <severine.queune@bulac.fr> >--- > C4/Reports/Guided.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/C4/Reports/Guided.pm b/C4/Reports/Guided.pm >index 76940954ad..295e1312e7 100644 >--- a/C4/Reports/Guided.pm >+++ b/C4/Reports/Guided.pm >@@ -656,7 +656,7 @@ sub update_sql { > my $cache_expiry = $fields->{cache_expiry}; > my $public = $fields->{public}; > >- $sql =~ s/(\s*\;\s*)$//; # removes trailing whitespace and /;/ >+ $sql =~ s/(\s*\;\s*)$// if defined $sql; # removes trailing whitespace and /;/ > my $report = Koha::Reports->find($id); > $report->last_modified(dt_from_string); > $report->savedsql($sql); >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 26669
:
115165
|
115166
|
115414
|
131539
|
132547
|
132548
|
132549
|
132587
|
132588
|
132589
|
132590