Attachment 132576 Details for Bug 30394 – Bug 30394: Unit tests

[patch] Bug 30394: Unit tests

Bug-30394-Unit-tests.patch (text/plain), 1.31 KB, created by Tomás Cohen Arazi (tcohen) on 2022-03-30 12:03:33 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tomás Cohen Arazi (tcohen)

Created: 2022-03-30 12:03:33 UTC

Size: 1.31 KB

patch

obsolete

>From 9cdef5ceb5238072c55f9234c365701b7f697582 Mon Sep 17 00:00:00 2001
>From: Tomas Cohen Arazi <tomascohen@theke.io>
>Date: Wed, 30 Mar 2022 13:43:50 +0200
>Subject: [PATCH] Bug 30394: Unit tests
>
>This patch adds tests for checking the x-koha-request-id header is
>returned on GET routes that have it enabled, and then the request
>includes it.
>
>To test:
>1. Apply this patch
>2. Run:
>   $ kshell
>  k$ prove t/db_dependent/api/v1/query.t
>=> FAIL: The feature is not implemented, tests fail
>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
>---
> t/db_dependent/api/v1/query.t | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
>diff --git a/t/db_dependent/api/v1/query.t b/t/db_dependent/api/v1/query.t
>index e986ab708e..dd73f2095c 100755
>--- a/t/db_dependent/api/v1/query.t
>+++ b/t/db_dependent/api/v1/query.t
>@@ -34,7 +34,7 @@ t::lib::Mocks::mock_preference( 'RESTBasicAuth', 1 );
> 
> subtest 'q handling tests' => sub {
> 
>-    plan tests => 15;
>+    plan tests => 17;
> 
>     $schema->storage->txn_begin;
> 
>@@ -100,5 +100,8 @@ subtest 'q handling tests' => sub {
> 
>     is( scalar @{$cities}, 1, 'empty list as first query, 1 city retrieved' );
> 
>+    $t->get_ok("//$userid:$password@/api/v1/cities" => { 'x-koha-request-id' => 100 } )
>+      ->header_is( 'x-koha-request-id' => 100 );
>+
>     $schema->storage->txn_rollback;
> };
>-- 
>2.35.1

Actions: View | Diff | Splinter Review

Attachments on bug 30394: 132576 | 132577 | 132578 | 132579 | 132582 | 132583 | 132584 | 132585 | 132598 | 132599 | 132600 | 132601 | 132602