Bugzilla – Attachment 132597 Details for
Bug 30393
datatables wrapper should handle searching for %, _ and \
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 30393: Make datatables wrapper handle searching for %, _, \
Bug-30393-Make-datatables-wrapper-handle-searching.patch (text/plain), 1.94 KB, created by
Martin Renvoize (ashimema)
on 2022-03-30 12:37:57 UTC
(
hide
)
Description:
Bug 30393: Make datatables wrapper handle searching for %, _, \
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2022-03-30 12:37:57 UTC
Size:
1.94 KB
patch
obsolete
>From 1c6e6c93f4ca52308f0dfee86626e782723be37d Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@theke.io> >Date: Wed, 30 Mar 2022 12:10:26 +0200 >Subject: [PATCH] Bug 30393: Make datatables wrapper handle searching for %, _, > \ >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >This patch makes searching for '%','_' and '\' work by escaping those >symbols in the query before sending them to the API. > >To test: >1. Go to the cities page >2. Add two cities: > - 'Cordoba %' > - 'Buenos Aires _' > - 'London \' >3. Use the column search on the name, alternating _, \ and % as the query >=> FAIL: Weird behavior >4. Apply this patch and reload >5. Repeat 3 >=> SUCCESS: Filtering works correctly! >6. Sign off :-D > >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >Signed-off-by: Séverine Queune <severine.queune@bulac.fr> >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > koha-tmpl/intranet-tmpl/prog/js/datatables.js | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/js/datatables.js b/koha-tmpl/intranet-tmpl/prog/js/datatables.js >index 2d88fcdd05..12dd6683ae 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/datatables.js >+++ b/koha-tmpl/intranet-tmpl/prog/js/datatables.js >@@ -556,8 +556,11 @@ jQuery.fn.dataTable.ext.errMode = function(settings, note, message) { > _per_page: length > }; > >- > function build_query(col, value){ >+ >+ // escape SQL special characters >+ value = value.replace(/(\%|\_|\\)/g, "\\$1" ); >+ > var parts = []; > var attributes = col.data.split(':'); > for (var i=0;i<attributes.length;i++){ >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 30393
:
132544
|
132551
|
132553
|
132561
| 132597