Attachment 132657 Details for Bug 30118 – Bug 30118: (QA follow-up) Fix Perl Critic issues

[patch] Bug 30118: (QA follow-up) Fix Perl Critic issues

Bug-30118-QA-follow-up-Fix-Perl-Critic-issues.patch (text/plain), 1.04 KB, created by Kyle M Hall (khall) on 2022-03-30 16:39:32 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2022-03-30 16:39:32 UTC

Size: 1.04 KB

patch

obsolete

>From 113aee5ef3d440421d1846ba6b8b44f432916762 Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatersolutions.com>
>Date: Wed, 30 Mar 2022 16:34:55 +0000
>Subject: [PATCH] Bug 30118: (QA follow-up) Fix Perl Critic issues
>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>---
> C4/SIP/ILS/Transaction/Checkin.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/C4/SIP/ILS/Transaction/Checkin.pm b/C4/SIP/ILS/Transaction/Checkin.pm
>index bba433415e..7274f82c35 100644
>--- a/C4/SIP/ILS/Transaction/Checkin.pm
>+++ b/C4/SIP/ILS/Transaction/Checkin.pm
>@@ -89,7 +89,7 @@ sub do_checkin {
> 
>     my $reserved;
>     my $lookahead = C4::Context->preference('ConfirmFutureHolds'); #number of days to look for future holds
>-    my ($resfound, $resrec, undef) = C4::Reserves::CheckReserves( $item->itemnumber, undef, $lookahead ) unless ( $item->withdrawn );
>+    my ($resfound) = $item->withdrawn ? q{} : C4::Reserves::CheckReserves( $item->itemnumber, undef, $lookahead );
>     if ( $resfound eq "Reserved") {
>         $reserved = 1;
>     }
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 30118: 130703 | 132626 | 132656 | 132657