Attachment 132662 Details for Bug 30404 – Bug 30404: Enlarge all patron search pop-ups

[patch] Bug 30404: Enlarge all patron search pop-ups

Bug-30404-Enlarge-all-patron-search-pop-ups.patch (text/plain), 6.20 KB, created by Jonathan Druart on 2022-03-31 08:34:01 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2022-03-31 08:34:01 UTC

Size: 6.20 KB

patch

obsolete

>From f429726a3bcb5b0afeb8b3ea9bf32b4a0eb3b6ea Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Thu, 31 Mar 2022 10:30:22 +0200
>Subject: [PATCH] Bug 30404: Enlarge all patron search pop-ups
>
>Enlarging the pop-ups will hide the scrollbars (at least the horizontal
>one).
>
>Test plan:
>Search for patrons (when a new pop-up is opened) and confirm that the
>pop-up is bigger than without this patch.
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt       | 2 +-
> .../intranet-tmpl/prog/en/modules/acqui/neworderempty.tt      | 2 +-
> koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqbudgets.tt    | 4 ++--
> .../intranet-tmpl/prog/en/modules/patroncards/edit-batch.tt   | 2 +-
> koha-tmpl/intranet-tmpl/prog/en/modules/serials/routing.tt    | 2 +-
> .../intranet-tmpl/prog/en/modules/suggestion/suggestion.tt    | 4 ++--
> 6 files changed, 8 insertions(+), 8 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt
>index 9ef5b60c625..c4a43aebb6f 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt
>@@ -1012,7 +1012,7 @@
>             window.open(
>                 "/cgi-bin/koha/members/search.pl?columns=cardnumber,name,category,branch,action&selection_type=add&filter=baskets_managers",
>                 'UserSearchPopup',
>-                'width=840, height=500, scrollbars=yes, toolbar=no,'
>+                'width=1024, height=768, scrollbars=yes, toolbar=no,'
>              );
>         }
> 
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt
>index 21d0b112c86..2e80630d826 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt
>@@ -686,7 +686,7 @@
>             window.open(
>                 "/cgi-bin/koha/members/search.pl?columns=cardnumber,name,category,branch,action&selection_type=add",
>                 'UserSearchPopup',
>-                'width=740, height=450, scrollbars=yes, toolbar=no,'
>+                'width=1024, height=768, scrollbars=yes, toolbar=no,'
>              );
>         }
> 
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqbudgets.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqbudgets.tt
>index 347f79f9c68..cf5852d20aa 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqbudgets.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqbudgets.tt
>@@ -497,7 +497,7 @@
>             function userPopup() {
>                 window.open("/cgi-bin/koha/members/search.pl?columns=cardnumber,name,category,branch,action&selection_type=add&filter=funds_users",
>                     'PatronPopup',
>-                    'width=740,height=450,location=yes,toolbar=no,'
>+                    'width=1024,height=768,location=yes,toolbar=no,'
>                     + 'scrollbars=yes,resize=yes'
>                 );
>             }
>@@ -505,7 +505,7 @@
>             function ownerPopup() {
>                 window.open("/cgi-bin/koha/members/search.pl?columns=cardnumber,name,category,branch,action&selection_type=select&filter=funds_owners",
>                     'PatronPopup',
>-                    'width=740,height=450,location=yes,toolbar=no,'
>+                    'width=1024,height=768,location=yes,toolbar=no,'
>                     + 'scrollbars=yes,resize=yes'
>                 );
>             }
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/edit-batch.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/edit-batch.tt
>index 2589e6dfe5b..4ef824d5edf 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/edit-batch.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/edit-batch.tt
>@@ -187,7 +187,7 @@
>             if (bor_nums.value == '') {
>                 window.open("/cgi-bin/koha/members/search.pl?columns=cardnumber,name,category,branch,dateexpiry,borrowernotes,action&selection_type=add",
>                'PatronPopup',
>-               'width=840,height=500,location=yes,toolbar=no,'
>+               'width=1024,height=768,location=yes,toolbar=no,'
>                + 'scrollbars=yes,resize=yes');
>             } else {
>                 document.forms["add_by_bor_num"].submit();
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/routing.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/routing.tt
>index d9c8bf68f2e..93f691cbe4f 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/routing.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/routing.tt
>@@ -144,7 +144,7 @@
>         function userPopup() {
>             window.open("/cgi-bin/koha/members/search.pl?columns=cardnumber,name,category,branch,action&selection_type=add",
>                 'PatronPopup',
>-                'width=740,height=450,location=yes,toolbar=no,'
>+                'width=1024,height=768,scrollbars=yes,toolbar=no,'
>                 + 'scrollbars=yes,resize=yes'
>             );
>         }
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt
>index 99309134cc8..1f691dcf93b 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt
>@@ -1220,7 +1220,7 @@
>             tab = selected_tab;
>             window.open("/cgi-bin/koha/members/search.pl?columns=cardnumber,name,branch,category,action&selection_type=select&callback=select_manager&filter=suggestions_managers",
>                 'PatronPopup',
>-                'width=740,height=450,location=yes,toolbar=no,'
>+                'width=1024,height=768,scrollbars=yes,toolbar=no,'
>                 + 'scrollbars=yes,resize=yes'
>             );
>         }
>@@ -1257,7 +1257,7 @@
>         function editSuggesterPopup() {
>             window.open("/cgi-bin/koha/members/search.pl?columns=cardnumber,name,branch,category,action&selection_type=select&callback=select_suggester",
>                 'PatronPopup',
>-                'width=740,height=450,location=yes,toolbar=no,'
>+                'width=1024,height=768,scrollbars=yes,toolbar=no,'
>                 + 'scrollbars=yes,resize=yes'
>             );
>         }
>-- 
>2.25.1

Actions: View | Diff | Splinter Review

Attachments on bug 30404: 132662 | 132750 | 132780