Bugzilla – Attachment 132793 Details for
Bug 30419
Convert authority detail page tabs to Bootstrap
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 30419: Convert authority detail page tabs to Bootstrap
Bug-30419-Convert-authority-detail-page-tabs-to-Bo.patch (text/plain), 2.61 KB, created by
Owen Leonard
on 2022-03-31 15:43:47 UTC
(
hide
)
Description:
Bug 30419: Convert authority detail page tabs to Bootstrap
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2022-03-31 15:43:47 UTC
Size:
2.61 KB
patch
obsolete
>From bceed59d288431cdad06e5ab887190fae7d40b8a Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Thu, 31 Mar 2022 13:43:41 +0000 >Subject: [PATCH] Bug 30419: Convert authority detail page tabs to Bootstrap > >This patch updates the authority detail page to use Bootstrap tabs >instead of jQueryUI. > >The patch also removes some broken JavaScript. It will be re-implemented >in Bug 30422. > >To test, apply the patch search for an authority record in the >authorities module. > >View the detail page for the authority and test that the tabs look >correct and work correctly. >--- > .../prog/en/modules/authorities/detail.tt | 22 +++++++++---------- > 1 file changed, 10 insertions(+), 12 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/detail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/detail.tt >index 4c720bfc83..c2ed977238 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/detail.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/detail.tt >@@ -68,16 +68,16 @@ > </div> > > <div id="authoritiestabs" class="toptabs numbered"> >- <ul> >+ <ul class="nav nav-tabs" role="tablist"> > [% FOREACH BIG_LOO IN BIG_LOOP %] >- <li> >- <a href="#tab[% BIG_LOO.number | uri %]XX">[% BIG_LOO.number | html %]</a> >+ <li role="presentation"> >+ <a href="#tab[% BIG_LOO.number | uri %]XX" aria-controls="tab[% BIG_LOO.number | uri %]XX" role="tab" data-toggle="tab">[% BIG_LOO.number | html %]</a> > </li> > [% END %] > </ul> >- >+ <div class="tab-content"> > [% FOREACH BIG_LOO IN BIG_LOOP %] >- <div id="tab[% BIG_LOO.number | html %]XX"> >+ <div id="tab[% BIG_LOO.number | html %]XX" role="tabpanel" class="tab-pane"> > [% FOREACH innerloo IN BIG_LOO.innerloop %] > [% IF ( innerloo.tag_number ) %] > <div class="tag"> >@@ -116,6 +116,7 @@ > [% END %] > </div> > [% END %] >+</div> <!-- /.tab-content --> > </div> > </div> > </div> >@@ -128,13 +129,10 @@ > [% END %] > <script> > $(document).ready(function() { >- var editAuth = $("#editAuth"); >- var editAuthLink = editAuth.attr("href"); >- $('#authoritiestabs').tabs({ >- activate: function( event, ui ){ >- editAuth.attr("href", editAuthLink + "#" + ui.newPanel.attr('id') ); >- } >- }); >+ if( $(".tab-pane.active").length < 1 ){ >+ $("#authoritiestabs a:first").tab("show"); >+ } >+ > [% IF ( displayhierarchy ) %] > $('#hierarchies').jstree({ > "types" : { >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 30419
:
132793
|
132823
|
132913