Bugzilla – Attachment 132805 Details for
Bug 26019
Koha should set SameSite attribute on cookies
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 26019: Add two other js cookies
Bug-26019-Add-two-other-js-cookies.patch (text/plain), 2.01 KB, created by
Kyle M Hall (khall)
on 2022-03-31 18:01:45 UTC
(
hide
)
Description:
Bug 26019: Add two other js cookies
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2022-03-31 18:01:45 UTC
Size:
2.01 KB
patch
obsolete
>From bbf5f04c765b0167b628d2d92add50874056e29e Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Thu, 17 Mar 2022 12:45:34 +0000 >Subject: [PATCH] Bug 26019: Add two other js cookies > >Test plan: >Same as former patch. Use OPAC adv search here. > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> > >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >--- > .../opac-tmpl/bootstrap/en/modules/opac-advsearch.tt | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt >index cd21067de1..98562bdd36 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt >@@ -512,18 +512,18 @@ $(document).ready(function() { > } > }); > form_serialized = $(this).serialize(); >- Cookies.set("form_serialized", JSON.stringify( form_serialized ), { path: '/'}); >+ Cookies.set("form_serialized", JSON.stringify( form_serialized ), { path: '/', sameSite: 'Lax' }); > form_serialized_limits = [ > $('#language-limit').val(), $('#branchloop').val(), > $('#subtype_audience').val(), $('#subtype_content').val(), > $('#subtype_format').val(), $('#subtype_additional').val(), > $('#locloop').val() > ]; >- Cookies.set("form_serialized_limits", JSON.stringify( form_serialized_limits ),{ path: '/'}); >+ Cookies.set("form_serialized_limits", JSON.stringify( form_serialized_limits ),{ path: '/', sameSite: 'Lax' }); > [% IF ( expanded_options ) %] >- Cookies.set("search_path_code", 'exs', { path: '/'}); >+ Cookies.set("search_path_code", 'exs', { path: '/', sameSite: 'Lax' }); > [% ELSE %] >- Cookies.set("search_path_code", 'ads', { path: '/'}); >+ Cookies.set("search_path_code", 'ads', { path: '/', sameSite: 'Lax' }); > [% END %] > }); > >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 26019
:
130565
|
130566
|
131836
|
131837
|
132804
|
132805
|
133212
|
133213
|
133214