Attachment 132858 Details for Bug 30417 – Bug 30417: Switch to Bootstrap tabs on the basic library transfer limit page

[patch] Bug 30417: Switch to Bootstrap tabs on the basic library transfer limit page

Bug-30417-Switch-to-Bootstrap-tabs-on-the-basic-li.patch (text/plain), 3.02 KB, created by Kyle M Hall (khall) on 2022-04-01 12:39:30 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2022-04-01 12:39:30 UTC

Size: 3.02 KB

patch

obsolete

>From db17c62240d394ce5898df1e8ad115dc158efb0c Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Thu, 31 Mar 2022 13:16:46 +0000
>Subject: [PATCH] Bug 30417: Switch to Bootstrap tabs on the basic library
> transfer limit page
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>This patch updates the basic library transfer limits  page to use
>Bootstrap tabs instead of jQueryUI.
>
>To test, apply the patch and go to Administraion -> Library transfer
>limits.
>
>Test that the tabs look correct and work correctly. The functionality of
>the page should be unchanged.
>
>Signed-off-by: SÃ©verine Queune <severine.queune@bulac.fr>
>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>---
> .../en/modules/admin/branch_transfer_limits.tt | 18 +++++++++++++-----
> 1 file changed, 13 insertions(+), 5 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/branch_transfer_limits.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/branch_transfer_limits.tt
>index 86f9fa56cb..801eeb7795 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/branch_transfer_limits.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/branch_transfer_limits.tt
>@@ -53,14 +53,18 @@
> 
> 
>   <div id="transferlimit_tabs" class="toptabs">
>-    <ul class="ui-tabs-nav">
>-      [% FOREACH codes_loo IN codes_loop %]<li><a href="#[% codes_loo.code | uri %]set">[% codes_loo.code | html %]</a></li>[% END %]
>+    <ul class="nav nav-tabs" role="tablist">
>+        [% FOREACH codes_loo IN codes_loop %]
>+            <li role="presentation">
>+                <a href="#[% codes_loo.code | uri %]set" aria-controls="[% codes_loo.code | uri %]set" role="tab" data-toggle="tab">[% codes_loo.code | html %]</a>
>+            </li>
>+        [% END %]
>     </ul>
>-
>         <form method="post" action="branch_transfer_limits.pl">
>+    <div class="tab-content">
> 
>     [% FOREACH codes_loo IN codes_loop %]
>-    <div id="[% codes_loo.code | html %]set">
>+    <div role="tabpanel" class="tab-pane" id="[% codes_loo.code | html %]set">
>     <h4>Policy for [% codes_loo.limit_phrase | html %]: [% codes_loo.code | html %]</h4>
> 
>     <p><a id="CheckAll[% codes_loo.code | html %]table" data-cb="[% codes_loo.code | html %]" class="checkall" href="#"><i class="fa fa-check"></i> Select all</a> | <a id="UncheckAll[% codes_loo.code | html %]table" data-cb="[% codes_loo.code | html %]" class="uncheckall" href="#"><i class="fa fa-remove"></i> Clear all</a></p>
>@@ -90,6 +94,7 @@
>         </table>
>         </div>
>                 [% END %]
>+        </div>
> 
>         <fieldset class="action">
>             <input type="hidden" name="updateLimits" value="1" />
>@@ -128,7 +133,10 @@
>                     $(this).prop("checked", false);
>                 });
>             });
>-            $('#transferlimit_tabs').tabs();
>+
>+            if( $(".tab-pane.active").length < 1 ){
>+                  $("#transferlimit_tabs a:first").tab("show");
>+            }
> 
>              $('#branchselect').change(function() {
>                 $('#selectlibrary').submit();
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 30417: 132758 | 132826 | 132858