Bugzilla – Attachment 132880 Details for
Bug 27783
Introduce background job queues
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 27783: (QA follow-up) Make dbrev idempotent
Bug-27783-QA-follow-up-Make-dbrev-idempotent.patch (text/plain), 1.67 KB, created by
Tomás Cohen Arazi (tcohen)
on 2022-04-02 10:58:43 UTC
(
hide
)
Description:
Bug 27783: (QA follow-up) Make dbrev idempotent
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2022-04-02 10:58:43 UTC
Size:
1.67 KB
patch
obsolete
>From 0df5163eb191735d7f502ac6073e9d3ddd2a6f78 Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@theke.io> >Date: Sat, 2 Apr 2022 12:58:25 +0200 >Subject: [PATCH] Bug 27783: (QA follow-up) Make dbrev idempotent > >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >--- > .../data/mysql/atomicupdate/bug-27783.pl | 21 ++++++++++++------- > 1 file changed, 13 insertions(+), 8 deletions(-) > >diff --git a/installer/data/mysql/atomicupdate/bug-27783.pl b/installer/data/mysql/atomicupdate/bug-27783.pl >index 7fee204990..1f17eb6ea5 100644 >--- a/installer/data/mysql/atomicupdate/bug-27783.pl >+++ b/installer/data/mysql/atomicupdate/bug-27783.pl >@@ -7,14 +7,19 @@ return { > my ($args) = @_; > my ($dbh, $out) = @$args{qw(dbh out)}; > >- $dbh->do(q{ >- ALTER TABLE `background_jobs` >- ADD `queue` VARCHAR(191) COLLATE utf8mb4_unicode_ci NOT NULL DEFAULT 'default' COMMENT 'Name of the queue the job is sent to' AFTER `type` >- }); >- $dbh->do(q{ >- ALTER TABLE `background_jobs` >- ADD KEY `queue` (`queue`) >- }); >+ unless ( column_exists( 'background_jobs', 'queue' ) ) { >+ $dbh->do(q{ >+ ALTER TABLE `background_jobs` >+ ADD COLUMN `queue` VARCHAR(191) COLLATE utf8mb4_unicode_ci NOT NULL DEFAULT 'default' COMMENT 'Name of the queue the job is sent to' AFTER `type` >+ }); >+ } >+ >+ unless ( index_exists( 'background_jobs', 'queue' ) ) { >+ $dbh->do(q{ >+ ALTER TABLE `background_jobs` >+ ADD KEY `queue` (`queue`) >+ }); >+ } > > say $out "Added background_jobs.queue"; > }, >-- >2.35.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 27783
:
132642
|
132644
|
132649
|
132650
|
132651
|
132846
|
132847
|
132848
|
132849
|
132850
|
132875
|
132876
|
132877
|
132878
|
132879
|
132880
|
132948
|
132950
|
132951
|
133160
|
133161
|
133162
|
133163
|
133164
|
133165
|
133166
|
133167
|
133168
|
133169
|
133170
|
133171
|
133172
|
133173
|
133174
|
133175
|
133176
|
133177
|
133178
|
133179