Attachment 132892 Details for Bug 27631 – Bug 27631: catalogue and tags folders

[patch] Bug 27631: catalogue and tags folders

Bug-27631-catalogue-and-tags-folders.patch (text/plain), 7.07 KB, created by Katrin Fischer on 2022-04-02 22:04:30 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2022-04-02 22:04:30 UTC

Size: 7.07 KB

patch

obsolete

>From e792aab6239a55266e2a736928f91e41a5207b06 Mon Sep 17 00:00:00 2001
>From: Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz>
>Date: Wed, 7 Apr 2021 01:23:49 +0000
>Subject: [PATCH] Bug 27631: catalogue and tags folders
>
>Changed each of the pages in the catalogue and tags folders to have one
><h1> tag showing that describes the page, rather than the <h1>
>describing the logo.
>
>The hierarchy of heading tags may be broken in many pages, but this
>will be dealt with in an additional bug.
>
>To test:
>1) Go to the Staff Client
>2) Apply patch
>3) Go to each of the pages in the catalogue and tags folders and check
>   that they have an obvious and descriptive heading
>4) Ensure that the heading in the page is <h1>
>
>Sponsored-by: Catalyst IT
>
>Signed-off-by: Owen Leonard <oleonard@myacpl.org>
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> .../prog/en/modules/catalogue/ISBDdetail.tt            |  8 ++++++++
> .../prog/en/modules/catalogue/MARCdetail.tt            |  1 +
> .../intranet-tmpl/prog/en/modules/catalogue/detail.tt  |  8 ++++++++
> .../prog/en/modules/catalogue/imageviewer.tt           |  2 +-
> .../prog/en/modules/catalogue/labeledMARCdetail.tt     | 10 ++++++++--
> .../prog/en/modules/catalogue/moredetail.tt            |  2 ++
> .../intranet-tmpl/prog/en/modules/catalogue/results.tt |  2 ++
> koha-tmpl/intranet-tmpl/prog/en/modules/tags/list.tt   |  2 ++
> 8 files changed, 32 insertions(+), 3 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/ISBDdetail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/ISBDdetail.tt
>index 258879e691..00e019de88 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/ISBDdetail.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/ISBDdetail.tt
>@@ -50,6 +50,14 @@
>         <div class="col-sm-10 col-sm-push-2">
>             <main>
> 
>+                <h1>
>+                    [% IF ( unknownbiblionumber ) %]
>+                        Unknown record
>+                    [% ELSE %]
>+                        ISBD details for [% INCLUDE 'biblio-title-head.inc' %]
>+                    [% END %]
>+                </h1>
>+
> [% IF ( unknownbiblionumber ) %]
>     <div class="dialog message">The record you requested does not exist ([% biblionumber | html %]).</div>
> [% ELSE %]
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/MARCdetail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/MARCdetail.tt
>index 9ffb148515..1a4ecb6b86 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/MARCdetail.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/MARCdetail.tt
>@@ -52,6 +52,7 @@
>             <main>
> 
> [% IF ( unknownbiblionumber ) %]
>+    <h1>Unknown record</h1>
>   <div class="dialog message">The record you requested does not exist ([% biblionumber | html %]).</div>
> [% ELSE %]
> 
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
>index 5eca90dcf2..0b5874e9af 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
>@@ -83,6 +83,14 @@
>             <main>
>                 <div class="row">
> 
>+                    <h1>
>+                        [% IF ( unknownbiblionumber ) %]
>+                            Unknown record
>+                        [% ELSE %]
>+                            Details for [% INCLUDE 'biblio-title-head.inc' %]
>+                        [% END %]
>+                    </h1>
>+
> [% IF ( unknownbiblionumber ) %]
>   <div class="dialog message">The record you requested does not exist ([% biblionumber | html %]).</div>
> [% ELSE %]
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/imageviewer.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/imageviewer.tt
>index 5e76e1e3e3..63cbeea4c4 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/imageviewer.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/imageviewer.tt
>@@ -53,7 +53,7 @@
> 
> [% INCLUDE 'cat-toolbar.inc' %]
> 
>-<h3>Images for <em>[% INCLUDE 'biblio-title.inc' %]</em></h3>
>+<h1>Images for <em>[% INCLUDE 'biblio-title.inc' %]</em></h1>
> <h4>[% biblio.author | html %]</h4>
> 
> [% IF ( LocalCoverImages == 1 ) %]
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/labeledMARCdetail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/labeledMARCdetail.tt
>index 2887a8c75d..4c1d4931e3 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/labeledMARCdetail.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/labeledMARCdetail.tt
>@@ -44,14 +44,20 @@
>         <div class="col-sm-10 col-sm-push-2">
>             <main>
> 
>+                <h1>
>+                    [% IF ( unknownbiblionumber ) %]
>+                        Unknown record
>+                    [% ELSE %]
>+                        Labeled MARC biblio : [% biblionumber | html %]  ( [% bibliotitle | html %] )
>+                    [% END %]
>+                </h1>
>+
>     [% IF ( unknownbiblionumber ) %]
>         <div class="dialog message">The record you requested does not exist ([% biblionumber | html %]).</div>
>     [% ELSE %]
> 
> 					[% INCLUDE 'cat-toolbar.inc' %]
> 
>-					[% UNLESS ( popup ) %]
>-                        <h1>Labeled MARC biblio : [% biblionumber | html %]  ( [% bibliotitle | html %] )</h1>
> 					[% END %]
>                     <p><strong>With framework:
>                     <select name="Frameworks" id="Frameworks" onchange="Changefwk(this);">
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt
>index 745e0192d0..6db25bb690 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt
>@@ -39,6 +39,8 @@
>         <div class="col-sm-10 col-sm-push-2">
>             <main>
> 
>+            <h1>Item details for [% INCLUDE 'biblio-title-head.inc' %]</h1>
>+
> [% INCLUDE 'cat-toolbar.inc' %]
> 
> <div id="catalogue_detail_biblio">
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt
>index 0251cbe792..c407a646c4 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt
>@@ -52,6 +52,8 @@
>         <div class="col-sm-10 col-sm-push-2">
>             <main>
> 
>+            <h1>Search results</h1>
>+
>                 [% IF ( outer_sup_results_loop ) %]
>                     <div class="row">
>                         <div class="col-sm-8">
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tags/list.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tags/list.tt
>index 60946fe730..cc25b9f11d 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tags/list.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tags/list.tt
>@@ -37,6 +37,8 @@ tr.selected { background-color : #FFFFCC; } tr.selected td { background-color :
>         <div class="col-sm-10 col-sm-push-2">
>             <main>
> 
>+                <h1>Results for tag <em>[% tag | html %]</em></h1>
>+
> [% IF ( titles ) %]
> <h3>Titles tagged with the term <em>[% tag | html %]</em></h3>
> <table id="itemst">
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 27631: 116352 | 119492 | 119493 | 119496 | 119497 | 119498 | 119500 | 119501 | 119502 | 119544 | 119545 | 119546 | 119547 | 119830 | 119831 | 119832 | 119834 | 119835 | 119836 | 119837 | 119838 | 119839 | 119840 | 119841 | 119842 | 119843 | 120158 | 120159 | 120160 | 120161 | 120162 | 120166 | 120190 | 120191 | 121356 | 121469 | 121470 | 121522 | 121559 | 125547 | 125548 | 125549 | 125550 | 125551 | 125552 | 125553 | 125554 | 125555 | 125556 | 125557 | 125558 | 125559 | 125560 | 125561 | 125562 | 125563 | 125564 | 127295 | 127296 | 127297 | 127298 | 127299 | 127300 | 127301 | 127302 | 127303 | 127304 | 127305 | 127306 | 127307 | 127308 | 127309 | 127310 | 127311 | 127312 | 127432 | 127433 | 127449 | 127456 | 131069 | 131070 | 131071 | 131072 | 131073 | 131074 | 131075 | 131076 | 131077 | 131078 | 131079 | 131080 | 131081 | 131082 | 131083 | 131084 | 131085 | 131086 | 131087 | 131192 | 132886 | 132887 | 132888 | 132889 | 132890 | 132891 | 132892 | 132893 | 132894 | 132895 | 132896 | 132897 | 132898 | 132899 | 132900 | 132901 | 132902 | 132903 | 132904 | 132905