Bugzilla – Attachment 132930 Details for
Bug 30432
get_items_that_can_fill needs to specify table for biblionumbers
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 30432: Unit test
Bug-30432-Unit-test.patch (text/plain), 1.77 KB, created by
Owen Leonard
on 2022-04-04 11:48:51 UTC
(
hide
)
Description:
Bug 30432: Unit test
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2022-04-04 11:48:51 UTC
Size:
1.77 KB
patch
obsolete
>From 925001dddc5462ce898408729d654acc8b0907b8 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Fri, 1 Apr 2022 12:48:27 +0000 >Subject: [PATCH] Bug 30432: Unit test > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> >--- > t/db_dependent/Koha/Holds.t | 15 ++++++++++++++- > 1 file changed, 14 insertions(+), 1 deletion(-) > >diff --git a/t/db_dependent/Koha/Holds.t b/t/db_dependent/Koha/Holds.t >index 2d99dedd41..a44ee6ae20 100755 >--- a/t/db_dependent/Koha/Holds.t >+++ b/t/db_dependent/Koha/Holds.t >@@ -411,7 +411,7 @@ subtest 'Desks' => sub { > }; > > subtest 'get_items_that_can_fill' => sub { >- plan tests => 5; >+ plan tests => 6; > > my $biblio = $builder->build_sample_biblio; > my $itype_1 = $builder->build_object({ class => 'Koha::ItemTypes' }); # For 1, 2, 3, 4 >@@ -503,6 +503,19 @@ subtest 'get_items_that_can_fill' => sub { > is_deeply( [ map { $_->itemnumber } $items->as_list ], > [ $item_2->itemnumber ], 'Only item 2 is available for filling the hold' ); > >+ >+ my $noloan_itype = $builder->build_object( { class => 'Koha::ItemTypes', value => { notforloan => 1 } } ); >+ t::lib::Mocks::mock_preference( 'item-level_itypes', 0 ); >+ Koha::Holds->find( $waiting_reserve_id )->delete; >+ $holds = Koha::Holds->search( >+ { >+ reserve_id => [ $reserve_id_1, $reserve_id_2 ] >+ } >+ ); >+ $items = $holds->get_items_that_can_fill; >+ is_deeply( [ map { $_->itemnumber } $items->as_list ], >+ [ $item_1->itemnumber, $item_2->itemnumber, $item_5->itemnumber ], 'Items 1, 2, and 5 are available for filling the holds' ); >+ > my $no_holds = Koha::Holds->new->empty(); > my $no_items = $no_holds->get_items_that_can_fill(); > is( ref $no_items, "Koha::Items", "Routine returns a Koha::Items object"); >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 30432
:
132862
|
132863
|
132930
|
132931
|
133039
|
133040
|
133041
|
133877