Attachment 132960 Details for Bug 30426 – Bug 30426: Add missing C4::Auth and C4::Output imports

[patch] Bug 30426: Add missing C4::Auth and C4::Output imports

Bug-30426-Add-missing-C4Auth-and-C4Output-imports.patch (text/plain), 1.35 KB, created by Jonathan Druart on 2022-04-05 12:20:36 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2022-04-05 12:20:36 UTC

Size: 1.35 KB

patch

obsolete

>From 7eecb336e2a76a14be202772d2d5ca40703ca5d7 Mon Sep 17 00:00:00 2001
>From: David Cook <dcook@prosentient.com.au>
>Date: Thu, 31 Mar 2022 23:02:35 +0000
>Subject: [PATCH] Bug 30426: Add missing C4::Auth and C4::Output imports
>
>This patch adds missing function imports for C4::Auth and C4::Output
>in the opac/svc/suggestion script.
>
>Test plan:
>
>1. Go to http://localhost:8081/cgi-bin/koha/admin/didyoumean.pl
>2. Turn on some plugins
>3. Go to http://localhost:8080/cgi-bin/koha/opac-search.pl?idx=&q=test&weight_search=1
>4. Note in your browser's Network tab that the call to
>   http://localhost:8080/cgi-bin/koha/svc/suggestion?render=stub&q=test
>   generates a 200 response instead of a 500 error
>
>Signed-off-by: Owen Leonard <oleonard@myacpl.org>
>
>Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>---
> opac/svc/suggestion | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/opac/svc/suggestion b/opac/svc/suggestion
>index 04b0655b34b..0f8cd5d0d49 100755
>--- a/opac/svc/suggestion
>+++ b/opac/svc/suggestion
>@@ -53,9 +53,9 @@ Number of suggestions to display. Defaults to 4 in stub mode, 20 otherwise.
> 
> use Modern::Perl;
> 
>-use C4::Auth;
>+use C4::Auth qw( get_template_and_user );
> use C4::Context;
>-use C4::Output;
>+use C4::Output qw( output_html_with_http_headers );
> use CGI qw ( -utf8 );
> use JSON;
> use Koha::SuggestionEngine;
>-- 
>2.25.1

Actions: View | Diff | Splinter Review

Attachments on bug 30426: 132813 | 132929 | 132960