Bugzilla – Attachment 132971 Details for
Bug 17506
Offline circ needs to be logged
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 17506: Offline circ needs to be logged
Bug-17506-Offline-circ-needs-to-be-logged.patch (text/plain), 1.67 KB, created by
Kyle M Hall (khall)
on 2022-04-05 13:10:51 UTC
(
hide
)
Description:
Bug 17506: Offline circ needs to be logged
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2022-04-05 13:10:51 UTC
Size:
1.67 KB
patch
obsolete
>From c935fba2dc879640bc99047614d17ffe54f0a705 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Tue, 5 Apr 2022 09:07:01 -0400 >Subject: [PATCH] Bug 17506: Offline circ needs to be logged > >Returns via offline circ are not logged. > >Test Plan: >1) Via offline circ > * Return some items checked out to patrons > * Check out some items that are currently checked out to other > patrons >2) Apply the offline circs to Koha >3) Note the checkouts are logged, but not the returns >4) Apply this patch, restart all the things! >5) Repeat steps 1 and 2 >6) Note the checkins are now logged both for returns and for checkouts > where the item was checked out to a different patron >--- > C4/Circulation.pm | 8 ++++++++ > 1 file changed, 8 insertions(+) > >diff --git a/C4/Circulation.pm b/C4/Circulation.pm >index c6baf4892f..54817ff775 100644 >--- a/C4/Circulation.pm >+++ b/C4/Circulation.pm >@@ -4020,6 +4020,10 @@ sub ProcessOfflineReturn { > $item->renewals(0); > $item->onloan(undef); > $item->store({ log_action => 0 }); >+ >+ logaction("CIRCULATION", "RETURN", $issue->{borrowernumber}, $itemnumber) >+ if C4::Context->preference("ReturnLog"); >+ } > return "Success."; > } else { > return "Item not issued."; >@@ -4048,6 +4052,10 @@ sub ProcessOfflineIssue { > $itemnumber, > $operation->{timestamp}, > ); >+ >+ logaction("CIRCULATION", "RETURN", $issue->{borrowernumber}, $itemnumber) >+ if C4::Context->preference("ReturnLog"); >+ } > } > AddIssue( > $patron->unblessed, >-- >2.32.0 (Apple Git-132)
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 17506
:
132971
|
147842
|
151697
|
151698
|
151699
|
151707
|
151708
|
176184
|
176185