Bugzilla – Attachment 133040 Details for
Bug 30432
get_items_that_can_fill needs to specify table for biblionumbers
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 30432: Specify 'me' for biblionumber when limiting items
Bug-30432-Specify-me-for-biblionumber-when-limitin.patch (text/plain), 1.23 KB, created by
Jonathan Druart
on 2022-04-06 14:35:30 UTC
(
hide
)
Description:
Bug 30432: Specify 'me' for biblionumber when limiting items
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2022-04-06 14:35:30 UTC
Size:
1.23 KB
patch
obsolete
>From 356edeb535e01ef8da3fdb8c4de9ca4eba763920 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Fri, 1 Apr 2022 12:48:54 +0000 >Subject: [PATCH] Bug 30432: Specify 'me' for biblionumber when limiting items > >To test: >1 - Apply only unit tests >2 - prove t/db_dependent/Koha/Holds.t >3 - It fails >4 - Apply this patch >5 - prove t/db_dependent/Koha/Holds.t >6 - It passes! > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >--- > Koha/Holds.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/Koha/Holds.pm b/Koha/Holds.pm >index 5784cd70475..0d062d06208 100644 >--- a/Koha/Holds.pm >+++ b/Koha/Holds.pm >@@ -118,7 +118,7 @@ sub get_items_that_can_fill { > my @biblionumbers = $self->search({ 'me.itemnumber' => undef })->get_column('biblionumber'); > my @bibs_or_items; > push @bibs_or_items, 'me.itemnumber' => { in => \@itemnumbers } if @itemnumbers; >- push @bibs_or_items, 'biblionumber' => { in => \@biblionumbers } if @biblionumbers; >+ push @bibs_or_items, 'me.biblionumber' => { in => \@biblionumbers } if @biblionumbers; > > my @branchtransfers = Koha::Item::Transfers->search( > { datearrived => undef }, >-- >2.25.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 30432
:
132862
|
132863
|
132930
|
132931
|
133039
| 133040 |
133041
|
133877