Bugzilla – Attachment 133112 Details for
Bug 12285
Allow easy printing of patron's fines
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 12285: Don't print fines with undef amountoutstanding
0001-Bug-12285-Don-t-print-fines-with-undef-amountoutstan.patch (text/plain), 1.20 KB, created by
Emmi Takkinen
on 2022-04-08 10:06:26 UTC
(
hide
)
Description:
Bug 12285: Don't print fines with undef amountoutstanding
Filename:
MIME Type:
Creator:
Emmi Takkinen
Created:
2022-04-08 10:06:26 UTC
Size:
1.20 KB
patch
obsolete
>From 3b3537dd1670821d512fe787cc1f62739f181c53 Mon Sep 17 00:00:00 2001 >From: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> >Date: Fri, 8 Apr 2022 13:02:50 +0300 >Subject: [PATCH] Bug 12285: Don't print fines with undef amountoutstanding > >Accountlines with undefined amountoutstading value are >printed in fineslip. > >To test: >1) Find patron with credit type accountlines. >2) Edit some of those lines from database, set their >amountoutstanding as NULL. >3) Print fineslip. >=> Note that edited credit lines are displayed in the >fineslip. >4) Apply patch. >5) Print fineslip. >=> Note that lines are no longer displayed in the >fineslip. > >Sponsored-by: Koha-Suomi Oy >--- > C4/Members.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/C4/Members.pm b/C4/Members.pm >index fd8e3fbf0d..66d4e5018a 100644 >--- a/C4/Members.pm >+++ b/C4/Members.pm >@@ -702,7 +702,7 @@ sub FineSlip { > my @issueslist; > > while (my $line = $lines->next) { >- next if ($line->amountoutstanding =~ /^0.0+$/); >+ next if ( !$line->amountoutstanding || $line->amountoutstanding =~ /^0.0+$/ ); > > my $item = Koha::Items->find({itemnumber => $line->itemnumber}); > $item = $item ? $item->unblessed : undef; >-- >2.25.1 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 12285
:
28327
|
29144
|
29692
|
123202
|
123203
|
123243
|
129723
|
129724
|
129922
|
129923
|
129937
|
129943
|
129944
|
129945
|
129946
|
129947
|
133112
|
133147
|
139037
|
139038
|
139039
|
139040
|
139041
|
139042
|
140795
|
140796
|
140797
|
140798
|
140799
|
140800