Attachment 13319 Details for Bug 8163 – [Signed off] Bug 8163 [REVISED] Click to populate XSLT preferences with "default" or empty values

[patch] [Signed off] Bug 8163 [REVISED] Click to populate XSLT preferences with "default" or empty values

Bug-8163-REVISED-Click-to-populate-XSLT-preference.patch (text/plain), 6.25 KB, created by Melia Meggs on 2012-11-08 19:23:47 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Melia Meggs

Created: 2012-11-08 19:23:47 UTC

Size: 6.25 KB

patch

obsolete

>From 04bbb2c1826f4ebc89b2ca04b93cbcfbe86a76c5 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Tue, 29 May 2012 15:07:32 -0400
>Subject: [PATCH] Bug 8163 [REVISED] Click to populate XSLT preferences with "default" or empty values
>
>This patch adds markup and JavaScript to the system preferences
>interface so that the user can click "default" or "empty" to populate
>an XSLT-related pref with those vaules.
>
>To test, open system preferences for the OPAC or staff client. In
>the description for an XSLT-related preference click the "default"
>link to populate the field with "default." Click the "leave empty"
>link to empty the field.
>
>Revised according to Julian Maurice's suggestion for a more
>generic, flexible way to implement it.
>
>Signed-off-by: Melia Meggs <melia@test.bywatersolutions.com>
>---
> .../intranet-tmpl/prog/en/js/pages/preferences.js | 10 ++++++++++
> .../prog/en/modules/admin/preferences/opac.pref | 4 ++--
> .../en/modules/admin/preferences/staff_client.pref | 4 ++--
> 3 files changed, 14 insertions(+), 4 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/js/pages/preferences.js b/koha-tmpl/intranet-tmpl/prog/en/js/pages/preferences.js
>index 93dfaac..80b0fc6 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/js/pages/preferences.js
>+++ b/koha-tmpl/intranet-tmpl/prog/en/js/pages/preferences.js
>@@ -59,6 +59,16 @@ $( document ).ready( function () {
> mark_modified.call(this);
> } );
> 
>+ $(".set_syspref").click(function() {
>+ var s = $(this).attr('data-syspref');
>+ var v = $(this).attr('data-value');
>+ // populate the input with the value in data-value
>+ $("#pref_"+s).val(v);
>+ // pass the DOM element to trigger "modified" to enable submit button
>+ mark_modified.call($("#pref_"+s)[0]);
>+ return false;
>+ });
>+
> window.onbeforeunload = function () {
> if ( KOHA.Preferences.Modified ) {
> return MSG_MADE_CHANGES;
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref
>index 1a9fa09..2866f8d 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref
>@@ -59,12 +59,12 @@ OPAC:
> - 'Display OPAC results using XSLT stylesheet at: '
> - pref: OPACXSLTResultsDisplay
> class: file
>- - ' Options: - leave empty for "no xslt" - enter "default" for the default one - put a path to define a xslt file - put an URL for an external specific stylesheet. {langcode} will be replaced with current interface language'
>+ - ' Options:<ul><li><a href="#" class="set_syspref" data-syspref="OPACXSLTResultsDisplay" data-value="">Leave empty</a> for "no xslt"</li><li>enter "<a href="#" class="set_syspref" data-syspref="OPACXSLTResultsDisplay" data-value="default">default</a>" for the default one</li><li> put a path to define a xslt file</li><li>put an URL for an external specific stylesheet.</li></ul>{langcode} will be replaced with current interface language'
> -
> - 'Display OPAC details using XSLT stylesheet at: '
> - pref: OPACXSLTDetailsDisplay
> class: file
>- - ' Options: - leave empty for "no xslt" - enter "default" for the default one - put a path to define a xslt file - put an URL for an external specific stylesheet. {langcode} will be replaced with current interface language'
>+ - ' Options:<ul><li><a href="#" class="set_syspref" data-syspref="OPACXSLTDetailsDisplay" data-value="">Leave empty</a> for "no xslt"</li><li>enter "<a href="#" class="set_syspref" data-syspref="OPACXSLTDetailsDisplay" data-value="default">default</a>" for the default one</li><li>put a path to define a xslt file</li><li>put an URL for an external specific stylesheet.</li></ul>{langcode} will be replaced with current interface language'
> -
> - On pages displayed with XSLT stylesheets on the OPAC,
> - pref: DisplayOPACiconsXSLT
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/staff_client.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/staff_client.pref
>index b6be289..d9fc21a 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/staff_client.pref
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/staff_client.pref
>@@ -59,12 +59,12 @@ Staff Client:
> - 'Display results in the staff client using XSLT stylesheet at: '
> - pref: XSLTResultsDisplay
> class: file
>- - ' Options: - leave empty for "no xslt" - enter "default" for the default one - put a path to define a xslt file - put an URL for an external specific stylesheet. {langcode} will be replaced with current interface language'
>+ - ' Options:<ul><li><a href="#" class="set_syspref" data-syspref="XSLTResultsDisplay" data-value="">Leave empty</a> for "no xslt"</li><li>enter "<a href="#" class="set_syspref" data-syspref="XSLTResultsDisplay" data-value="default">default</a>" for the default one</li><li> put a path to define a xslt file</li><li>put an URL for an external specific stylesheet.</li></ul>{langcode} will be replaced with current interface language'
> -
> - 'Display details in the staff client using XSLT stylesheet at: '
> - pref: XSLTDetailsDisplay
> class: file
>- - ' Options: - leave empty for "no xslt" - enter "default" for the default one - put a path to define a xslt file - put an URL for an external specific stylesheet. {langcode} will be replaced with current interface language'
>+ - ' Options:<ul><li><a href="#" class="set_syspref" data-syspref="XSLTDetailsDisplay" data-value="">Leave empty</a> for "no xslt"</li><li>enter "<a href="#" class="set_syspref" data-syspref="XSLTDetailsDisplay" data-value="default">default</a>" for the default one</li><li>put a path to define a xslt file</li><li>put an URL for an external specific stylesheet.</li></ul>{langcode} will be replaced with current interface language'
> -
> - Use the Yahoo UI libraries
> - pref: yuipath
>-- 
>1.7.2.5

Actions: View | Diff | Splinter Review

Attachments on bug 8163: 9840 | 11086 | 11107 | 11109 | 13181 | 13319