Attachment 133200 Details for Bug 30510 – Bug 30510: Add Patron reason column to suggestion tables

[patch] Bug 30510: Add Patron reason column to suggestion tables

Bug-30510-Add-Patron-reason-column-to-suggestion-t.patch (text/plain), 3.07 KB, created by Lucas Gass (lukeg) on 2022-04-11 21:43:57 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Lucas Gass (lukeg)

Created: 2022-04-11 21:43:57 UTC

Size: 3.07 KB

patch

obsolete

>From dd6bc434291db1c8189b4598db98ddc5c13d7eec Mon Sep 17 00:00:00 2001
>From: Lucas Gass <lucas@bywatersolutions.com>
>Date: Mon, 11 Apr 2022 21:36:16 +0000
>Subject: [PATCH] Bug 30510: Add Patron reason column to suggestion tables
>
>To test:
>1. Make some patron reasons for suggestion via Home > Administration > Authorized values > OPAC_SUG
>2. Give those reasons a description.
>3. Make several suggestions via staff client and/or OPAC and apply some of the reasons you just made
>4. Apply patch
>5. Go to Home > Acquistions > Suggestions management
>6. Give some of the suggestions some different status (PENDING/REJECTED/ACCEPTED/ect)
>7. Make sure on each of the tables you can see the column 'Patron reason'
>8. Go to Administration > Table settings and attempt to hide the column.
>9. Confirm that the column is properly hidden on the Suggestions management page
>---
> admin/columns_settings.yml                                      | 2 ++
> .../intranet-tmpl/prog/en/modules/suggestion/suggestion.tt      | 2 ++
> 2 files changed, 4 insertions(+)
>
>diff --git a/admin/columns_settings.yml b/admin/columns_settings.yml
>index 1a91d8c6f5..2bfd7243c3 100644
>--- a/admin/columns_settings.yml
>+++ b/admin/columns_settings.yml
>@@ -170,6 +170,8 @@ modules:
>               columnname: suggested_by
>             -
>               columnname: suggested_on
>+            -
>+              columnname: patron_reason
>             -
>               columnname: managed_by
>             -
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt
>index 1f691dcf93..b8133b88bc 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt
>@@ -729,6 +729,7 @@
>                                         <th class="anti-the">Suggestion</th>
>                                         <th>Suggested by</th>
>                                         <th>Suggested on</th>
>+                                        <th>Patron reason</th>
>                                         <th>Managed by</th>
>                                         <th>Managed on</th>
>                                         <th>Last modification by</th>
>@@ -789,6 +790,7 @@
>                                             <td data-order="[% suggestions_loo.suggesteddate | html %]">
>                                                 [% IF ( suggestions_loo.suggesteddate ) %][% suggestions_loo.suggesteddate | $KohaDates %][% END %]
>                                             </td>
>+                                            <td>[% AuthorisedValues.GetByCode( 'OPAC_SUG', suggestions_loo.patronreason ) | html %]</td>
>                                             <td>
>                                                 <a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% suggestions_loo.managedby | uri %]">[% suggestions_loo.surnamemanagedby | html %][% IF ( suggestions_loo.firstnamemanagedby ) %], [% suggestions_loo.firstnamemanagedby | html %][% END %]</a>
>                                             </td>
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 30510: 133200 | 133406 | 133726 | 133846