Attachment 133283 Details for Bug 18392 – Bug 18392: use KohaTable for circ rules to allow export of matrix

[patch] Bug 18392: use KohaTable for circ rules to allow export of matrix

Bug-18392-use-KohaTable-for-circ-rules-to-allow-ex.patch (text/plain), 1.72 KB, created by Lucas Gass (lukeg) on 2022-04-13 20:12:01 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Lucas Gass (lukeg)

Created: 2022-04-13 20:12:01 UTC

Size: 1.72 KB

patch

obsolete

>From 07e3d646b91930bc241e84cb166a3ef6072a828d Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Wed, 13 Apr 2022 19:10:43 +0000
>Subject: [PATCH] Bug 18392: use KohaTable for circ rules to allow export of
> matrix
>
>To test:
>1 - Define some circ rules
>2 - View them, note the appearance
>3 - Apply patch
>4 - Reload and note change of header
>5 - Use the new button to export, try various formats
>6 - Test the filter and export
>
>Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt
>index 0ee352fcb0..26db3f1a44 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt
>@@ -1200,9 +1200,10 @@
>     [% Asset.js("js/admin-menu.js") | $raw %]
>     [% INCLUDE 'datatables.inc' %]
>     [% INCLUDE 'calendar.inc' %]
>+    [% INCLUDE 'columns_settings.inc' %]
>     <script>
>          $(document).ready(function() {
>-            $("#default-circulation-rules").dataTable($.extend(true,{},dataTablesDefaults, {
>+            KohaTable("default-circulation-rules", {
>                 "aoColumnDefs": [
>                     { "bVisible": false, "aTargets": [ 0,2 ] },
>                     { "bSortable": false, "aTargets": ["_all"] }
>@@ -1210,7 +1211,7 @@
>                 "aaSortingFixed": [ [0,'asc'], [1,'asc'], [2,'asc'], [3,'asc'] ],
>                 "bPaginate": false,
>                 "bAutoWidth": false
>-            }));
>+            });
>         });
> 
>         function clear_edit(){
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 18392: 133280 | 133281 | 133283 | 133284 | 133339 | 133340