Attachment 133294 Details for Bug 30135 – Bug 30135: (follow-up) Rename accessor in failing test

[patch] Bug 30135: (follow-up) Rename accessor in failing test

Bug-30135-follow-up-Rename-accessor-in-failing-tes.patch (text/plain), 1.73 KB, created by Martin Renvoize (ashimema) on 2022-04-14 09:46:53 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2022-04-14 09:46:53 UTC

Size: 1.73 KB

patch

obsolete

>From 9b62d10bfcfc1cf08c18aabc01321a20fb56621d Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Thu, 14 Apr 2022 10:44:36 +0100
>Subject: [PATCH] Bug 30135: (follow-up) Rename accessor in failing test
>
>We renamed the LSQ seqment accessor from 'collection_code' to
>'sequenece_code' to more clearly reflect the EDI segment name instead of
>the Koha field we had mapped it to. (Especially as that mapping is not
>optionally to ccode or location).
>
>However, I forgot to update the corresponding test. This patch does that
>update.
>---
> t/Edifact.t | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
>diff --git a/t/Edifact.t b/t/Edifact.t
>index a98511e4e0..21109af523 100755
>--- a/t/Edifact.t
>+++ b/t/Edifact.t
>@@ -80,8 +80,8 @@ my $branch = $test_line->girfield('branch');
> is( $branch, 'ELIB', "branch returned" );
> my $fund_allocation = $test_line->girfield('fund_allocation');
> is( $fund_allocation, '660BOO_2013', "fund_allocation returned" );
>-my $collection_code = $test_line->girfield('collection_code');
>-is( $collection_code, 'EBOO', "collection_code returned" );
>+my $sequence_code = $test_line->girfield('sequence_code');
>+is( $sequence_code, 'EBOO', "sequence_code returned" );
> 
> #my $shelfmark = $test_line->girfield('shelfmark');
> #my $classification = $test_line->girfield('classification');
>@@ -118,8 +118,8 @@ is( $y, 'REF', 'Copy fund returned' );
> $y = $ol->girfield( 'branch', 4 );
> is( $y, 'SOU', 'Copy Branch returned' );
> 
>-$y = $ol->girfield( 'collection_code', 4 );
>-is( $y, 'ANF', 'Collection code returned' );
>+$y = $ol->girfield( 'sequence_code', 4 );
>+is( $y, 'ANF', 'Sequence code returned' );
> 
> $y = $ol->girfield( 'stock_category', 4 );
> is( $y, 'RS', 'Copy stock category returned' );
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 30135: 130879 | 130971 | 130972 | 131006 | 131007 | 131139 | 131140 | 131141 | 132694 | 132695 | 132696 | 132697 | 133259 | 133294