Bugzilla – Attachment 133388 Details for
Bug 30346
Editing circ rule with Overdue fines cap (amount) results in data loss and extra fines
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 30346: Correctly transfer values when editing rules
Bug-30346-Correctly-transfer-values-when-editing-r.patch (text/plain), 2.07 KB, created by
Martin Renvoize (ashimema)
on 2022-04-19 07:57:27 UTC
(
hide
)
Description:
Bug 30346: Correctly transfer values when editing rules
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2022-04-19 07:57:27 UTC
Size:
2.07 KB
patch
obsolete
>From 5353259170025011600b484527fc50236854b743 Mon Sep 17 00:00:00 2001 >From: Lucas Gass <lucas@bywatersolutions.com> >Date: Mon, 11 Apr 2022 19:35:14 +0000 >Subject: [PATCH] Bug 30346: Correctly transfer values when editing rules > >To test: >--Create a circulation rule with a value in "Overdue fines cap (amount), or edit an existing rule to add it >-Save the new (or edited) rule. >-Edit the same rule again to change any other field. Note that "Overdue fines cap (amount)" is now blank >-Save your edited rule - "Overdue fines cap (amount)" will save as blank. > >Apply patch > >--Create a circ rule with a value in Overdue fines cap (amount) and check "Cap fine at replacement price" for that same rule. >-Save the rule >-Try ediding the rule and make sure both of those values now save correctly. >-Add several more rules and try playing with both "Cap fine at replacement price" and "Overdue fines cap (amount)". Make sure everything saves right. > >Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt >index 0ee352fcb0..146a6dbb61 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt >@@ -1287,7 +1287,7 @@ > } > $(current_column).find("input[type='text']").val(input_value); > $(current_column).find("select").val(select_value); >- } else if ( i == 15 ) { >+ } else if ( i == 16 ) { > // specific processing for cap_fine_to_replacement_price > var cap_fine_to_replacement_price = $(this).find("input[type='checkbox']"); > $('#cap_fine_to_replacement_price').prop('checked', cap_fine_to_replacement_price.is(':checked') ); >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 30346
:
133198
|
133199
| 133388