Bugzilla – Attachment 133494 Details for
Bug 30457
Convert holds page tabs to Bootstrap
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 30457: (follow-up) Tweak markup around search form
Bug-30457-follow-up-Tweak-markup-around-search-for.patch (text/plain), 1.85 KB, created by
Martin Renvoize (ashimema)
on 2022-04-20 16:54:06 UTC
(
hide
)
Description:
Bug 30457: (follow-up) Tweak markup around search form
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2022-04-20 16:54:06 UTC
Size:
1.85 KB
patch
obsolete
>From 238e3b78cd7ecf60235af313f69f491b2230aeb2 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Wed, 20 Apr 2022 15:48:36 +0000 >Subject: [PATCH] Bug 30457: (follow-up) Tweak markup around search form > >This patch makes a change to the markup around the patron/clubs search >form on the holds page. This change prevents the Bootstrap tabs from >inheriting an unwanted margin from the fieldset.brief definition. > >The change also replaces a <label> tag with an <h2>. I think a heading >makes more sense than a free-floating <label>. > >To test, apply the patch and confirm that the holds page >(/cgi-bin/koha/reserve/request.pl?biblionumber=XXX) looks correct. > >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >index c1a6b751f4..338c6ef71e 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >@@ -151,12 +151,12 @@ > <p>No club with this name, please, try another</p> > </div> > [% END %] >- <fieldset class="brief"> >+ <fieldset> > [% UNLESS multi_hold %] > [% IF clubcount %] >- <label>Search patrons or clubs</label> >+ <h2>Search patrons or clubs</h2> > [% ELSE %] >- <label>Search patrons</label> >+ <h2>Search patrons</h2> > [% END %] > [% END %] > <div id="circ_holds_select" class="toptabs"> >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 30457
:
132980
|
133088
|
133491
|
133493
| 133494