Bugzilla – Attachment 133521 Details for
Bug 29602
We must be nicer with translators
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 29602: (follow-up) Fix missing filters
Bug-29602-follow-up-Fix-missing-filters.patch (text/plain), 5.66 KB, created by
Martin Renvoize (ashimema)
on 2022-04-21 06:55:54 UTC
(
hide
)
Description:
Bug 29602: (follow-up) Fix missing filters
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2022-04-21 06:55:54 UTC
Size:
5.66 KB
patch
obsolete
>From 2b6cdc2ca4a1bffabe0e65463bf8af098ef9b614 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Thu, 21 Apr 2022 07:52:03 +0100 >Subject: [PATCH] Bug 29602: (follow-up) Fix missing filters > >$KohaSpan is not seen as a filter by xt/find-missing-filters.t and thus >we need to filter the block variables before passing them to $KohaSpan > >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > .../background_jobs/batch_authority_record_modification.inc | 4 ++-- > .../background_jobs/batch_biblio_record_modification.inc | 4 ++-- > .../prog/en/includes/background_jobs/batch_hold_cancel.inc | 2 +- > .../includes/background_jobs/batch_item_record_deletion.inc | 2 +- > 4 files changed, 6 insertions(+), 6 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/background_jobs/batch_authority_record_modification.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/background_jobs/batch_authority_record_modification.inc >index d1ed00a125..867b70ddcd 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/background_jobs/batch_authority_record_modification.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/background_jobs/batch_authority_record_modification.inc >@@ -29,10 +29,10 @@ > [% authority_link = BLOCK %]<a href="/cgi-bin/koha/authorities/detail.pl?authid=[% m.authid | uri %]">[% m.authid | html %]</a>[% END %] > [% SWITCH m.code %] > [% CASE 'authority_not_modified' %] >- <span>Authority record [% authority_link | $KohaSpan %] has not been modified. An error occurred on modifying it</span> >+ <span>Authority record [% authority_link | url | $KohaSpan %] has not been modified. An error occurred on modifying it</span> > [% IF m.error %] ([% m.error | html %])[% END %]. > [% CASE 'authority_modified' %] >- <span>Authority record [% authority_link | $KohaSpan %] has successfully been modified.</span> >+ <span>Authority record [% authority_link | url | $KohaSpan %] has successfully been modified.</span> > [% END %] > </div> > [% END %] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/background_jobs/batch_biblio_record_modification.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/background_jobs/batch_biblio_record_modification.inc >index 7315c35c84..a8942ab5fc 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/background_jobs/batch_biblio_record_modification.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/background_jobs/batch_biblio_record_modification.inc >@@ -40,10 +40,10 @@ > [% biblio_link = BLOCK %]<a href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=[% m.biblionumber | uri %]">[% m.biblionumber | html %]</a>[% END %] > [% SWITCH m.code %] > [% CASE 'biblio_not_modified' %] >- <span>Bibliographic record [% biblio_link %] has not been modified. An error occurred on modifying it.</span> >+ <span>Bibliographic record [% biblio_link | url | $KohaSpan %] has not been modified. An error occurred on modifying it.</span> > [% IF m.error %] ([% m.error | html %])[% END %]. > [% CASE 'biblio_modified' %] >- <span>Bibliographic record [% biblio_link %] has successfully been modified.</span> >+ <span>Bibliographic record [% biblio_link | url | $KohaSpan %] has successfully been modified.</span> > [% END %] > </div> > [% END %] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/background_jobs/batch_hold_cancel.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/background_jobs/batch_hold_cancel.inc >index 280149b7fc..abf3d5035b 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/background_jobs/batch_hold_cancel.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/background_jobs/batch_hold_cancel.inc >@@ -40,7 +40,7 @@ > [% CASE 'hold_cancelled' %] > [% biblio_link = BLOCK %]<a href="/cgi-bin/koha/reserve/request.pl?biblionumber=[% m.biblio_id | uri %]">[% m.biblio.title | html %]</a>[% END %] > [% patron_link = BLOCK %]<a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% m.patron_id | uri %]">[% INCLUDE 'patron-title.inc' patron=m.patron %]</a>[% END %] >- <span>Hold on [% biblio_link | $KohaSpan %] for [% patron_link | $KohaSpan %] has successfully been cancelled.</span> >+ <span>Hold on [% biblio_link | url | $KohaSpan %] for [% patron_link | url | $KohaSpan %] has successfully been cancelled.</span> > [% END %] > </div> > [% END %] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/background_jobs/batch_item_record_deletion.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/background_jobs/batch_item_record_deletion.inc >index 4b552ec0c3..2bd9cd5e25 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/background_jobs/batch_item_record_deletion.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/background_jobs/batch_item_record_deletion.inc >@@ -41,7 +41,7 @@ > [% SWITCH m.code %] > [% CASE 'item_not_deleted' %] > [% item_link = BLOCK %]<a href="/cgi-bin/koha/catalogue/moredetail.pl?biblionumber=[% m.biblionumber | uri %]&itemnumber=[% m.itemnumber | uri %]">[% m.barcode | html %]</a>[% END %] >- <span>Item with barcode [% item_link | $KohaSpan%] cannot be deleted:</span> >+ <span>Item with barcode [% item_link | url | $KohaSpan %] cannot be deleted:</span> > [% SWITCH m.reason %] > [% CASE "book_on_loan" %]<span>Item is checked out</span> > [% CASE "not_same_branch" %]<span>Item does not belong to your library</span> >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 29602
:
128108
|
128109
|
128534
|
128535
|
128542
|
128543
|
130196
|
130197
|
130198
|
130199
|
130200
|
131421
|
131422
|
131423
|
131424
|
131425
|
131934
|
131935
|
131936
|
131937
|
131938
|
133129
|
133130
|
133131
|
133132
|
133133
|
133370
|
133371
|
133372
|
133373
|
133374
|
133381
|
133382
|
133383
|
133384
|
133385
|
133495
|
133521