Bugzilla – Attachment 133564 Details for
Bug 29894
2FA: Add few validations, clear secret, send register notice
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 29894: Db rev for adding notices
Bug-29894-Db-rev-for-adding-notices.patch (text/plain), 3.97 KB, created by
Martin Renvoize (ashimema)
on 2022-04-21 13:57:50 UTC
(
hide
)
Description:
Bug 29894: Db rev for adding notices
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2022-04-21 13:57:50 UTC
Size:
3.97 KB
patch
obsolete
>From 6f86e14e640bfe516f26602aef5f8796e91e0b15 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Fri, 21 Jan 2022 08:42:08 +0000 >Subject: [PATCH] Bug 29894: Db rev for adding notices > >This dbrev adds two notices: >2FA_REGISTER and 2FA_DEREGISTER > >Test plan: >Run the dbrev. >Check if you see them on Tools/Notices. > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > .../data/mysql/atomicupdate/bug_29894.pl | 16 +++++++++++ > .../mysql/en/mandatory/sample_notices.yml | 28 +++++++++++++++++++ > 2 files changed, 44 insertions(+) > create mode 100755 installer/data/mysql/atomicupdate/bug_29894.pl > >diff --git a/installer/data/mysql/atomicupdate/bug_29894.pl b/installer/data/mysql/atomicupdate/bug_29894.pl >new file mode 100755 >index 0000000000..1c040fc4b5 >--- /dev/null >+++ b/installer/data/mysql/atomicupdate/bug_29894.pl >@@ -0,0 +1,16 @@ >+use Modern::Perl; >+ >+return { >+ bug_number => 29894, >+ description => "Add 2FA (de)registering notices", >+ up => sub { >+ my ($args) = @_; >+ my ($dbh, $out) = @$args{qw(dbh out)}; >+ $dbh->do( q{ >+INSERT IGNORE INTO letter >+(module, code, branchcode, name, is_html, title, content, message_transport_type, lang) VALUES >+('members', '2FA_DEREGISTER', '', 'Confirmation of deregistering two factor authentication', 1, 'Confirmation of deregistering two factor authentication', '<p>Dear [% borrower.firstname %] [% borrower.surname %],</p>\r\n<p>This is to confirm that we deregistered two factor authentication for you.</p>\r\n<p>If you did not deregister, someone else may be using your account. Please contact technical support.</p>\r\n<p>Your library</p>', 'email', 'default'), >+('members', '2FA_REGISTER', '', 'Confirmation of registering two factor authentication', 1, 'Confirmation of registering two factor authentication', '<p>Dear [% borrower.firstname %] [% borrower.surname %],</p>\r\n<p>This is to confirm that we registered two factor authentication for you.</p>\r\n<p>If you did not register, someone else may be using your account. Please contact technical support.</p>\r\n<p>Your library</p>', 'email', 'default') >+ }); >+ }, >+}; >diff --git a/installer/data/mysql/en/mandatory/sample_notices.yml b/installer/data/mysql/en/mandatory/sample_notices.yml >index 42d1d08351..babef2a93c 100644 >--- a/installer/data/mysql/en/mandatory/sample_notices.yml >+++ b/installer/data/mysql/en/mandatory/sample_notices.yml >@@ -1632,3 +1632,31 @@ tables: > - "Callnumber: <<items.itemcallnumber>>" > - "Waiting since: <<recalls.waitingdate>>" > - "Notes: <<recalls.recallnotes>>" >+ >+ - module: members >+ code: 2FA_DEREGISTER >+ branchcode: "" >+ name: "Confirmation of deregistering two factor authentication" >+ is_html: 1 >+ title: "Confirmation of deregistering two factor authentication" >+ message_transport_type: email >+ lang: default >+ content: >+ - "<p>Dear [% borrower.firstname %] [% borrower.surname %],</p>" >+ - "<p>This is to confirm that we deregistered two factor authentication for you.</p>" >+ - "<p>If you did not deregister, someone else may be using your account. Please contact technical support.</p>" >+ - "<p>Your library</p>" >+ >+ - module: members >+ code: 2FA_REGISTER >+ branchcode: "" >+ name: "Confirmation of registering two factor authentication" >+ is_html: 1 >+ title: "Confirmation of registering two factor authentication" >+ message_transport_type: email >+ lang: default >+ content: >+ - "<p>Dear [% borrower.firstname %] [% borrower.surname %],</p>" >+ - "<p>This is to confirm that we registered two factor authentication for you.</p>" >+ - "<p>If you did not register, someone else may be using your account. Please contact technical support.</p>" >+ - "<p>Your library</p>" >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 29894
:
129538
|
129539
|
129669
|
129670
|
129689
|
129690
|
129691
|
129692
|
133286
|
133287
|
133288
|
133289
|
133562
|
133563
|
133564
|
133565
|
133566
|
133618
|
133661
|
133662
|
133663
|
133664
|
133665
|
133666
|
133667