Bugzilla – Attachment 133588 Details for
Bug 28998
Encrypt borrowers.secret
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 28998: (QA follow-up) POD Fix
Bug-28998-QA-follow-up-POD-Fix.patch (text/plain), 1.44 KB, created by
Martin Renvoize (ashimema)
on 2022-04-21 16:16:12 UTC
(
hide
)
Description:
Bug 28998: (QA follow-up) POD Fix
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2022-04-21 16:16:12 UTC
Size:
1.44 KB
patch
obsolete
>From 7a6ace2b88050eae883b6266b47fdcd675bb8620 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Thu, 21 Apr 2022 17:11:33 +0100 >Subject: [PATCH] Bug 28998: (QA follow-up) POD Fix > >This POD fix keeps the QA script happy > >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > Koha/Patron.pm | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > >diff --git a/Koha/Patron.pm b/Koha/Patron.pm >index 0363fe8db4..4aa5a2d410 100644 >--- a/Koha/Patron.pm >+++ b/Koha/Patron.pm >@@ -2132,12 +2132,12 @@ sub can_patron_change_staff_only_lists { > return 0; > } > >-=head3 >+=head3 encode_secret > >- $patron->encode_secret($secret32); >+ $patron->encode_secret($secret32); > >- Secret (TwoFactorAuth expects it in base32 format) is encrypted. >- You still need to call ->store. >+Secret (TwoFactorAuth expects it in base32 format) is encrypted. >+You still need to call ->store. > > =cut > >@@ -2149,12 +2149,12 @@ sub encode_secret { > return $self->secret($secret); > } > >-=head3 >+=head3 decoded_secret > >- my $secret32 = $patron->decoded_secret; >+ my $secret32 = $patron->decoded_secret; > >- Decode the patron secret. We expect to get back a base32 string, but this >- is not checked here. Caller of encode_secret is responsible for that. >+Decode the patron secret. We expect to get back a base32 string, but this >+is not checked here. Caller of encode_secret is responsible for that. > > =cut > >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 28998
:
124772
|
124773
|
124774
|
133291
|
133317
|
133318
|
133319
|
133320
|
133321
|
133322
|
133323
|
133523
|
133524
|
133525
|
133526
|
133527
|
133528
|
133529
|
133580
|
133581
|
133582
|
133583
|
133584
|
133585
|
133586
|
133588
|
133619
|
133620
|
133621
|
133622
|
133623
|
133624
|
133625
|
133626
|
133627
|
133628
|
133629
|
133631
|
133632
|
133633
|
133634
|
133635
|
133636
|
133637
|
133638
|
133639
|
133640
|
133641
|
133642
|
133645
|
133646
|
133647
|
133648
|
133649
|
133650
|
133651
|
133652
|
133653
|
133654
|
133655
|
134636
|
134637
|
134671