Attachment 133591 Details for Bug 30587 – Bug 30587: Fix opac-tags.tt translate issues

[patch] Bug 30587: Fix opac-tags.tt translate issues

Bug-30587-Fix-opac-tagstt-translate-issues.patch (text/plain), 1.75 KB, created by Tomás Cohen Arazi (tcohen) on 2022-04-21 16:42:42 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tomás Cohen Arazi (tcohen)

Created: 2022-04-21 16:42:42 UTC

Size: 1.75 KB

patch

obsolete

>From 754b90b8ef6ca72975feb1c8a8ab3a3536a127c2 Mon Sep 17 00:00:00 2001
>From: Tomas Cohen Arazi <tomascohen@theke.io>
>Date: Thu, 21 Apr 2022 13:24:06 -0300
>Subject: [PATCH] Bug 30587: Fix opac-tags.tt translate issues
>
>This patch addresses one specific case.
>
>To test:
>1. Run:
>   $ kshell
>  k$ cd misc/translator
>  k$ perl translate update es-ES
>2. On your git checkout run:
>   $ git diff | grep '\[% limit or'
>=> FAIL: That shouldn't be translated
>3. Run:
>   $ git reset --hard HEAD
>4. Apply this patch
>5. Repeat 1 and 2
>=> SUCCESS: No attempt to translate that tag
>6. Sign off :-D
>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
>---
> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-tags.tt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-tags.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-tags.tt
>index 382c0f15a11..8953297ab78 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-tags.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-tags.tt
>@@ -94,7 +94,7 @@
>                                             Tags to show:
>                                         [% END %]
>                                     </label>
>-                                    <input type="text" name="limit" class="form-control form-control-sm mr-2" maxlength="4" size="4" value="[% limit or "100" | html %]" />
>+                                    <input type="text" name="limit" class="form-control form-control-sm mr-2" maxlength="4" size="4" value="[% limit or '100' | html %]" />
>                                     <input type="submit" value="OK" class="btn btn-sm btn-primary" />
>                                 </div>
>                                 [% IF Koha.Preference( 'opacuserlogin' ) == 1 %]
>-- 
>2.34.1

Actions: View | Diff | Splinter Review

Attachments on bug 30587: 133591 | 133592 | 133770 | 133771 | 133784 | 133785