Attachment 133643 Details for Bug 28786 – Bug 28786: Fix 2FA selenium tests

[patch] Bug 28786: Fix 2FA selenium tests

Bug-28786-Fix-2FA-selenium-tests.patch (text/plain), 1.96 KB, created by Jonathan Druart on 2022-04-22 08:55:16 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2022-04-22 08:55:16 UTC

Size: 1.96 KB

patch

obsolete

>From 5f7103a1fcd24e2d9bf3636b0ce8f7d7214bf144 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Fri, 22 Apr 2022 10:54:42 +0200
>Subject: [PATCH] Bug 28786: Fix 2FA selenium tests
>
>Looks like there was a bad rebase at some point.
>---
> t/db_dependent/selenium/authentication_2fa.t | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
>diff --git a/t/db_dependent/selenium/authentication_2fa.t b/t/db_dependent/selenium/authentication_2fa.t
>index ebc0c7f991a..8e14a185f8f 100755
>--- a/t/db_dependent/selenium/authentication_2fa.t
>+++ b/t/db_dependent/selenium/authentication_2fa.t
>@@ -85,7 +85,7 @@ SKIP: {
>     };
> 
>     subtest 'Login' => sub {
>-        plan tests => 19;
>+        plan tests => 18;
> 
>         my $mainpage = $s->base_url . q|mainpage.pl|;
> 
>@@ -115,8 +115,7 @@ SKIP: {
>             is( login_error($s), undef );
>             $driver->find_element('//form[@id="loginform"]//input[@id="otp_token"]')->send_keys('wrong_code');
>             $driver->find_element('//input[@type="submit"]')->click;
>-            ok($driver->find_element('//div[@class="dialog error"][contains(text(), "Invalid two-factor code")]'));
>-            is( login_error($s), undef );
>+            is( login_error($s), "Invalid two-factor code" );
> 
>             $driver->get($mainpage);
>             like( $driver->get_title, qr(Two-factor authentication), 'Must still be on the second auth screen' );
>@@ -137,7 +136,7 @@ SKIP: {
>             is( login_error($s), undef );
>             $driver->find_element('//form[@id="loginform"]//input[@id="otp_token"]')->send_keys('wrong_code');
>             $driver->find_element('//input[@type="submit"]')->click;
>-            ok($driver->find_element('//div[@class="dialog error"][contains(text(), "Invalid two-factor code")]'));
>+            is( login_error($s), "Invalid two-factor code" );
> 
>             my $auth = Koha::Auth::TwoFactorAuth->new({patron => $patron});
>             my $code = $auth->code();
>-- 
>2.25.1

Actions: View | Diff | Splinter Review

Attachments on bug 28786: 123375 | 123376 | 123377 | 123378 | 123379 | 123380 | 123381 | 123397 | 123398 | 123399 | 123400 | 123401 | 123402 | 123403 | 124569 | 124770 | 124771 | 124844 | 124845 | 124846 | 124847 | 128841 | 128842 | 129383 | 129384 | 129474 | 129521 | 129557 | 129558 | 129559 | 129560 | 129561 | 129562 | 129563 | 129564 | 129565 | 129566 | 129567 | 129568 | 129569 | 129654 | 129655 | 129656 | 129657 | 129658 | 129659 | 129660 | 129661 | 129662 | 129665 | 131940 | 131941 | 131942 | 131943 | 131944 | 131945 | 131946 | 131947 | 131948 | 131949 | 131950 | 131951 | 131952 | 131953 | 131954 | 131955 | 131956 | 131957 | 131958 | 132142 | 132143 | 132144 | 132145 | 132146 | 132147 | 132148 | 132149 | 132150 | 132153 | 132154 | 132155 | 132156 | 132157 | 133222 | 133516 | 133522 | 133531 | 133533 | 133541 | 133548 | 133643 | 133686