Attachment 133644 Details for Bug 30595 – Bug 30595: Prevent update_child_to_adult.t to fail randomly

[patch] Bug 30595: Prevent update_child_to_adult.t to fail randomly

Bug-30595-Prevent-updatechildtoadultt-to-fail-rand.patch (text/plain), 1.73 KB, created by Jonathan Druart on 2022-04-22 09:43:50 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2022-04-22 09:43:50 UTC

Size: 1.73 KB

patch

obsolete

>From 897a230db75a154dafeef17d3b7d0a54a9ad9b5d Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Fri, 22 Apr 2022 11:42:09 +0200
>Subject: [PATCH] Bug 30595: Prevent update_child_to_adult.t to fail randomly
>
>t/db_dependent/selenium/update_child_to_adult.t ..         # Looks like you planned 3 tests but ran 2.
>
>    #   Failed test 'Update child to adult'
>    #   at t/db_dependent/selenium/update_child_to_adult.t line 132.
>    # Looks like you planned 3 tests but ran 2.
>    # Looks like you failed 1 test of 2 run.
>t/db_dependent/selenium/update_child_to_adult.t .. 1/1
> #   Failed test 'Update child to patron'
> #   at t/db_dependent/selenium/update_child_to_adult.t line 153.
>Cannot wait more for element '//input[@type="submit"]' to be visible at /kohadevbox/koha/t/lib/Selenium.pm line 189.
>
>It happens when there are too many patron's categories and the submit
>button is not in the viewport.
>---
> t/db_dependent/selenium/update_child_to_adult.t | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/t/db_dependent/selenium/update_child_to_adult.t b/t/db_dependent/selenium/update_child_to_adult.t
>index f821fe63998..5dbdec5b6dc 100755
>--- a/t/db_dependent/selenium/update_child_to_adult.t
>+++ b/t/db_dependent/selenium/update_child_to_adult.t
>@@ -122,6 +122,7 @@ subtest 'Update child to patron' => sub {
>         my $handles = $driver->get_window_handles;
>         $driver->switch_to_window($handles->[1]);
>         $driver->find_element('//input[@id="catcode'.$patron_category_A->categorycode.'"]')->click;
>+        $driver->set_window_size(1024, 768);
>         $s->submit_form;
> 
>         is( $child->get_from_storage->categorycode, $patron_category_A->categorycode, 'The child should now be an adult!' );
>-- 
>2.25.1

Actions: View | Diff | Splinter Review

Attachments on bug 30595: 133644