Bugzilla – Attachment 133673 Details for
Bug 29155
Upgrade jquery version to 3.6.0
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 29155: (follow-up) Work around change to jQueryUI tab API
Bug-29155-follow-up-Work-around-change-to-jQueryUI.patch (text/plain), 2.51 KB, created by
Jonathan Druart
on 2022-04-22 12:09:18 UTC
(
hide
)
Description:
Bug 29155: (follow-up) Work around change to jQueryUI tab API
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2022-04-22 12:09:18 UTC
Size:
2.51 KB
patch
obsolete
>From 301ba3e3182d2a10ce2a9669dc532eeb9e68799a Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Fri, 15 Apr 2022 11:45:08 +0000 >Subject: [PATCH] Bug 29155: (follow-up) Work around change to jQueryUI tab API > >For some reason, with the combination of jQuery 3.6.0 and jQueryUI >1.13.1, the way to access the current active tab's link has changed. >Previously the tab activate event would provide information about the >link as "ui.newTab.context." It appears that "context" is no longer >available. > >This patch updates the two instances in Koha where this process is >broken. > >To test, apply the patch and check out to a patron with holds on their >account. > >- When the checkout page loads, confirm that each tab loads its contents > correctly when clicked. >- Check that the correct tab is activated when you append the tab link > to the page url, e.g. > > /cgi-bin/koha/circ/circulation.pl?borrowernumber=XXX#reldebarments > > ...which should select the "Restrictions" tab for you. You may need to > try this in a new tab or shift-reload to get the browser to look for > the hash. > >- Perform the same tests on the patron details page. > >Signed-off-by: David Cook <dcook@prosentient.com.au> > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt | 2 +- > koha-tmpl/intranet-tmpl/prog/js/pages/circulation.js | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt >index 58c0f0a8639..2fe70202684 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt >@@ -893,7 +893,7 @@ > } > }, > "activate": function( event, ui ) { >- $('#'+ui.newTab.context.id).click(); >+ $("a", ui.newTab ).click(); > } > } ); > >diff --git a/koha-tmpl/intranet-tmpl/prog/js/pages/circulation.js b/koha-tmpl/intranet-tmpl/prog/js/pages/circulation.js >index cb63c56f0d8..6769d2e74ef 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/pages/circulation.js >+++ b/koha-tmpl/intranet-tmpl/prog/js/pages/circulation.js >@@ -11,7 +11,7 @@ $(document).ready(function() { > > $('#patronlists').tabs({ > activate: function( event, ui ) { >- $('#'+ui.newTab.context.id).click(); >+ $("a", ui.newTab ).click(); > } > }); > >-- >2.25.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 29155
:
130408
|
130409
|
133252
|
133253
|
133356
|
133378
|
133379
|
133380
|
133671
|
133672
| 133673