Bugzilla – Attachment 133677 Details for
Bug 30224
Wrong important field shown in cataloguing validation
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 30224: Show correct important field in cataloguing validation
Bug-30224-Show-correct-important-field-in-catalogu.patch (text/plain), 3.06 KB, created by
Jonathan Druart
on 2022-04-22 13:13:23 UTC
(
hide
)
Description:
Bug 30224: Show correct important field in cataloguing validation
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2022-04-22 13:13:23 UTC
Size:
3.06 KB
patch
obsolete
>From c118927573eefa8cd714f7f50e88b6ea9fbfd55a Mon Sep 17 00:00:00 2001 >From: Adam Styles <adam.styles@esa.edu.au> >Date: Fri, 4 Mar 2022 11:22:38 +1100 >Subject: [PATCH] Bug 30224: Show correct important field in cataloguing > validation > >This patch fxes the cataloguing validation messages to show the correct tag, when the whole field is important (not just a subfield). > >Note: Look at Bug 30159 to fix the formatting of the validation popup. > >1. Go to Administration -> MARC bibliographic frameworks >2. Click Actions next to a framework, view MARC structure >3. Edit multiple tags (at least 2) and check the Important checkbox. >4. Go to cataloguing and create a new record using the framework you just edited >5. Don't fill any of the important fields. Click Save to force the validation for the important tags >6. Notice that the error message shows that an important field isn't filled, but the tag number shown is repeated for each message. The 'Go to field' link goes to the right tag, but the tag number shown is incorrect. >7. Apply patch and refresh page >8. Click Save to force validation again. >9. Confirm the correct tag number is now showing for each error message. > >Sponsored-by: Education Services Australia SCIS >Signed-off-by: Petro Vashchuk <stalkernoid@gmail.com> > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >--- > .../intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt >index 00ea9c73f77..93b641bdfb7 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt >@@ -688,7 +688,7 @@ function PopupMARCFieldDoc(field) { > if( mandatoryFields[prop]["importance"] == "mandatory" ){ > StrAlert += "<li>" + _("Field %s is mandatory, at least one of its subfields must be filled.").format( prop ) + ' <a class="linkfield btn btn-link" href="#" data-tab="' + mandatoryFields[prop]["tab"] + '" data-field="' + mandatoryFields[prop]["elemid"] + '"><i class="fa fa-arrow-right" aria-hidden="true"></i> ' + _("Go to field") + '</a></li>'; > } else { >- StrAlert += "<li>" + _("Field %s is important, at least one of its subfields must be filled.").format(arr[0]) + ' <a class="linkfield btn btn-link" href="#" data-tab="' + mandatoryFields[prop]["tab"] + '" data-field="' + mandatoryFields[prop]["elemid"] + '"><i class="fa fa-arrow-right" aria-hidden="true"></i> ' + _("Go to field") + '</a></li>'; >+ StrAlert += "<li>" + _("Field %s is important, at least one of its subfields must be filled.").format(prop) + ' <a class="linkfield btn btn-link" href="#" data-tab="' + mandatoryFields[prop]["tab"] + '" data-field="' + mandatoryFields[prop]["elemid"] + '"><i class="fa fa-arrow-right" aria-hidden="true"></i> ' + _("Go to field") + '</a></li>'; > } > } > StrAlert += "</ul>"; >-- >2.25.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 30224
:
131367
|
133551
| 133677