Bugzilla – Attachment 133725 Details for
Bug 29768
hidepatronname hides guarantor name on borrower edit screen
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 29768: Do not hide guarantor name from memberentry.pl
0001-Bug-29768-Do-not-hide-guarantor-name-from.patch (text/plain), 4.01 KB, created by
Emmi Takkinen
on 2022-04-25 07:05:42 UTC
(
hide
)
Description:
Bug 29768: Do not hide guarantor name from memberentry.pl
Filename:
MIME Type:
Creator:
Emmi Takkinen
Created:
2022-04-25 07:05:42 UTC
Size:
4.01 KB
patch
obsolete
>From 2e7b86ffba8f3dd407c5d1882b8cc3b90bd8d0dc Mon Sep 17 00:00:00 2001 >From: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> >Date: Mon, 25 Apr 2022 10:04:21 +0300 >Subject: [PATCH] Bug 29768: Do not hide guarantor name from memberentry.pl > >Syspref "hidepatronname" currently hides guarantors name on memberentry.pl. >This is inconsistent since name isn't hidden e.g. on moremember.pl and staff >can already see patrons other personal information during edit. > >To test: >1) Disable syspref "hidepatronname" >2) Edit guarantee patrons information >=> Field "Guarantor" only shows guarantors cardnumber (or >is empty if guarantor has no cardnumber) >3) Apply patch >=> Guarantors name is now displayed (as a hyperlink) > >Also confirm hidepatronname still works as expected >on other pages (holds table, items detail page etc.). > >Sponsored-by: Koha-Suomi Oy >--- > koha-tmpl/intranet-tmpl/prog/en/includes/patron-title.inc | 2 +- > .../intranet-tmpl/prog/en/modules/members/memberentrygen.tt | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/patron-title.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/patron-title.inc >index e047700963..775c349e6f 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/patron-title.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/patron-title.inc >@@ -51,7 +51,7 @@ > [%- SET display_patron_name = 0 -%] > [%- END -%] > [%- END -%] >-[%- IF hide_patron_infos_if_needed AND ( display_patron_name OR display_cardnumber ) -%] >+[%- IF display_patron_name OR display_cardnumber -%] > [%- IF link_to == 'circulation_reserves' %]<a href="/cgi-bin/koha/circ/circulation.pl?borrowernumber=[% data.borrowernumber | uri %]#reserves"> > [%- ELSIF link_to == 'circulation_recalls' %]<a href="/cgi-bin/koha/circ/circulation.pl?borrowernumber=[% data.borrowernumber | uri %]#recalls"> > [%- ELSE %]<a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% data.borrowernumber | uri %]"> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt >index d01b2316bc..8f84d5b956 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt >@@ -440,7 +440,7 @@ legend:hover { > [% IF category_type == 'I' %] > <li class="guarantor-details" data-borrowernumber="[% r.guarantor_id | $raw %]"> > <span class="label">Organization:</span> >- [% INCLUDE 'patron-title.inc' patron=r.guarantor hide_patron_infos_if_needed=1 %] >+ [% INCLUDE 'patron-title.inc' patron=r.guarantor %] > </li> > <li> > <span class="label">Relationship:</span> >@@ -449,7 +449,7 @@ legend:hover { > [% ELSE %] > <li class="guarantor-details" data-borrowernumber="[% r.guarantor_id | $raw %]"> > <span class="label">Guarantor:</span> >- [% INCLUDE 'patron-title.inc' patron=r.guarantor hide_patron_infos_if_needed=1 %] >+ [% INCLUDE 'patron-title.inc' patron=r.guarantor %] > </li> > <li> > <span class="label">Relationship:</span> >-- >2.25.1 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 29768
:
133542
|
133725
|
134806
|
134807
|
139180
|
139181
|
142606
|
142607
|
145220