Bugzilla – Attachment 133733 Details for
Bug 30290
Article requests: Add TOC information to AR notices
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 30290: (follow-up) Add warning for translated notices
Bug-30290-follow-up-Add-warning-for-translated-not.patch (text/plain), 1.66 KB, created by
Katrin Fischer
on 2022-04-25 10:39:36 UTC
(
hide
)
Description:
Bug 30290: (follow-up) Add warning for translated notices
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2022-04-25 10:39:36 UTC
Size:
1.66 KB
patch
obsolete
>From dd69e4d8e9b72e1dbfe559856c9f1f92b8079f64 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Mon, 14 Mar 2022 13:01:22 +0000 >Subject: [PATCH] Bug 30290: (follow-up) Add warning for translated notices > >Note: Problem is that we cannot know if default was translated >or en contains the original notice. Actually this holds for >the other languages too. So this is an educated guess without >using the lang field. > >Test plan: >Run db rev. >Trigger the warning by replacing Pages by PPages in an AR notice. >Run db rev again. > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > installer/data/mysql/atomicupdate/bug_30290.pl | 9 +++++++++ > 1 file changed, 9 insertions(+) > >diff --git a/installer/data/mysql/atomicupdate/bug_30290.pl b/installer/data/mysql/atomicupdate/bug_30290.pl >index c367b4fda2..b2ed7cdb91 100755 >--- a/installer/data/mysql/atomicupdate/bug_30290.pl >+++ b/installer/data/mysql/atomicupdate/bug_30290.pl >@@ -12,5 +12,14 @@ SET content=REPLACE(content, '\nPages:', '\nTOC: [% IF article_request.toc_reque > WHERE code RLIKE '^AR_' AND module='circulation' AND content NOT RLIKE '\nTOC:'; > |; > $dbh->do( $sql ); >+ >+ # Warn if we find translated notices (educated guess with word Pages) >+ $sql=q| >+SELECT COUNT(*) >+FROM letter >+WHERE code RLIKE '^AR_' AND module='circulation' AND content NOT RLIKE '\nPages:'; >+ |; >+ my ( $count ) = $dbh->selectrow_array( $sql ); >+ say $out "WARNING: If you have translated AR notices, please add TOC lines yourself." if $count; > }, > }; >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 30290
:
131654
|
131655
|
131656
|
133468
|
133469
|
133470
|
133730
|
133731
|
133732
| 133733 |
133734