Bugzilla – Attachment 13404 Details for
Bug 5521
item edit form appears if no items found
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 5521 - item edit form appears if no items found
Bug-5521---item-edit-form-appears-if-no-items-foun.patch (text/plain), 2.21 KB, created by
Paul Poulain
on 2012-11-12 17:28:53 UTC
(
hide
)
Description:
Bug 5521 - item edit form appears if no items found
Filename:
MIME Type:
Creator:
Paul Poulain
Created:
2012-11-12 17:28:53 UTC
Size:
2.21 KB
patch
obsolete
>From 82f49c96ac74d07cf68fda47c098eed6a4e35aaf Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Tue, 30 Oct 2012 10:53:39 -0400 >Subject: [PATCH] Bug 5521 - item edit form appears if no items found > >This patch changes the template so that if no items are >found the page doesn't show "The following barcodes were found" >and doesn't show the item edit form. > >To test, submit a batch which contains no valid barcodes. >Compare to a batch which contains some or all valid barcodes. > >Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> >All tests succeed. > >Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> >--- > .../prog/en/modules/tools/batchMod-edit.tt | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-edit.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-edit.tt >index 8bf8fb8..c65277a 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-edit.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-edit.tt >@@ -81,8 +81,10 @@ $(document).ready(function(){ > [% END %] > </tbody> > </table> >- [% UNLESS ( too_many_items ) %] >- <h4>The following barcodes were found: </h4> >+ [% IF ( item_loop ) %] >+ [% UNLESS ( too_many_items ) %] >+ <h4>The following barcodes were found: </h4> >+ [% END %] > [% END %] > [% END %] <!-- /notfoundbarcodes --> > >@@ -143,6 +145,7 @@ $(document).ready(function(){ > [% END %] > [% END %]<!-- /too_many_items --> > >+[% IF ( item_loop ) %] > <div id="cataloguing_additem_newitem"> > <h2>Edit Items</h2> > <div class="hint">Checking the box right next the subfield label will disable the entry and delete the subfield on all selected items. Leave fields blank to make no change.</div> >@@ -182,6 +185,9 @@ $(document).ready(function(){ > <a href="/cgi-bin/koha/tools/batchMod.pl" class="cancel" onclick="history.back();return false;">Cancel</a> > </fieldset> > </div> >+[% ELSE %] >+ <p><a href="/cgi-bin/koha/tools/batchMod.pl">Return to batch item modification</a></p> >+[% END %] > [% ELSE %] <!-- // show --> > <fieldset class="action"> > [% IF ( src == 'CATALOGUING') %] >-- >1.7.9.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 5521
:
2884
|
13117
|
13143
| 13404