Attachment 134055 Details for Bug 30626 – Bug 30626: DT REST API wrapper - Fix general search

[patch] Bug 30626: DT REST API wrapper - Fix general search

Bug-30626-DT-REST-API-wrapper---Fix-general-search.patch (text/plain), 1.65 KB, created by Martin Renvoize (ashimema) on 2022-04-27 10:55:50 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2022-04-27 10:55:50 UTC

Size: 1.65 KB

patch

obsolete

>From 118bb805b225ac6b46c7b4aa6ba0e498ef4613c0 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Wed, 27 Apr 2022 12:33:03 +0200
>Subject: [PATCH] Bug 30626: DT REST API wrapper - Fix general search
>
>The general search query is not built correctly.
>
>Say you have a table with column filters, like the main patron search:
>General filter: henry
>Specific filter on the 'Name' column: h
>
>The generated query will be (= are actually LIKE):
>{ Column1="henry" AND Column3="henry", ...} AND { Column2="h" }
>
>The first term does not contain the Column2 attribute.
>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> koha-tmpl/intranet-tmpl/prog/js/datatables.js | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/js/datatables.js b/koha-tmpl/intranet-tmpl/prog/js/datatables.js
>index c33943df1e..48aab72e07 100644
>--- a/koha-tmpl/intranet-tmpl/prog/js/datatables.js
>+++ b/koha-tmpl/intranet-tmpl/prog/js/datatables.js
>@@ -600,7 +600,7 @@ jQuery.fn.dataTable.ext.errMode = function(settings, note, message) {
>                                 // Build query for the global search filter
>                                 var or_query_parameters = settings.aoColumns
>                                 .filter(function(col) {
>-                                    return col.bSearchable && typeof col.data == 'string' && data.columns[col.idx].search.value == '' && filter != ''
>+                                    return col.bSearchable
>                                 })
>                                 .map(function(col) {
>                                     var value = filter;
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 30626: 134016 | 134017 | 134055 | 134056 | 134057 | 134214 | 134215 | 134216 | 134252