Bugzilla – Attachment 134080 Details for
Bug 24001
Cannot edit card template
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 24001: Fix patron card template edition
Bug-24001-Fix-patron-card-template-edition.patch (text/plain), 1.92 KB, created by
Katrin Fischer
on 2022-04-27 15:24:48 UTC
(
hide
)
Description:
Bug 24001: Fix patron card template edition
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2022-04-27 15:24:48 UTC
Size:
1.92 KB
patch
obsolete
>From bd808795f5e0c110720a9234259f22cc63b5689b Mon Sep 17 00:00:00 2001 >From: Blou <blou@inlibro.com> >Date: Tue, 30 Jun 2020 12:50:09 -0400 >Subject: [PATCH] Bug 24001: Fix patron card template edition > >Error when saving Patron card Template: >Can't bless non-reference value at >/home/vagrant/kohaclone/C4/Creators/Profile.pm line 89 > >This is caused by the profile dropdown offering invalid choices and is >fixed by adding a filter to limit options to creator = 'Patroncards'. >The UI already handles the case where no valid profile is avaiable. > >Signed-off-by: Alexis Ripetti <alexis.ripetti@inLibro.com> > >Signed-off-by: David Nind <david@davidnind.com> > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> > >https://bugs.koha-community.org/show_bug.cgi?id=30373 >--- > patroncards/edit-template.pl | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/patroncards/edit-template.pl b/patroncards/edit-template.pl >index 0238701162..1c7a2cd411 100755 >--- a/patroncards/edit-template.pl >+++ b/patroncards/edit-template.pl >@@ -47,10 +47,10 @@ my $units = get_unit_values(); > > if ($op eq 'edit') { > $card_template = C4::Patroncards::Template->retrieve(template_id => $template_id); >- $profile_list = get_all_profiles({ fields => [ qw( profile_id printer_name paper_bin ) ], filters => {template_id => [ $template_id, '' ]} } ); >+ $profile_list = get_all_profiles({ fields => [ qw( profile_id printer_name paper_bin ) ], filters => {template_id => [ $template_id, 0 ], creator => 'Patroncards'} } ); > } > elsif ($op eq 'save') { >- my @params = ( profile_id => scalar $cgi->param('profile_id') || '', >+ my @params = ( profile_id => scalar $cgi->param('profile_id') || 0, > template_code => scalar $cgi->param('template_code'), > template_desc => scalar $cgi->param('template_desc'), > page_width => scalar $cgi->param('page_width'), >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 24001
:
95981
|
98722
|
99164
|
106434
|
109764
|
131381
|
131494
|
131495
|
134074
|
134075
|
134077
|
134078
|
134080
|
134081
|
134124
|
134125
|
134346