Bugzilla – Attachment 134097 Details for
Bug 29648
Make KohaTable tables 'default length' and 'default sort' configurable
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 29648: Allow tables_settings.default_display_length to be NULL
Bug-29648-Allow-tablessettingsdefaultdisplaylength.patch (text/plain), 2.15 KB, created by
Martin Renvoize (ashimema)
on 2022-04-27 16:09:18 UTC
(
hide
)
Description:
Bug 29648: Allow tables_settings.default_display_length to be NULL
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2022-04-27 16:09:18 UTC
Size:
2.15 KB
patch
obsolete
>From 4ff6de811d7c709845de80ce874d0a462c5d9ad2 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Thu, 16 Dec 2021 12:41:06 +0100 >Subject: [PATCH] Bug 29648: Allow tables_settings.default_display_length to be > NULL > >We actually want this value to be NULL. If set to NULL and >default_display_length is not in the yml, then the option will not be >displayed. > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > installer/data/mysql/atomicupdate/bug_29648_2.pl | 14 ++++++++++++++ > installer/data/mysql/kohastructure.sql | 2 +- > 2 files changed, 15 insertions(+), 1 deletion(-) > create mode 100755 installer/data/mysql/atomicupdate/bug_29648_2.pl > >diff --git a/installer/data/mysql/atomicupdate/bug_29648_2.pl b/installer/data/mysql/atomicupdate/bug_29648_2.pl >new file mode 100755 >index 0000000000..555fb676e7 >--- /dev/null >+++ b/installer/data/mysql/atomicupdate/bug_29648_2.pl >@@ -0,0 +1,14 @@ >+use Modern::Perl; >+ >+return { >+ bug_number => "29648", >+ description => "Allow tables_settings.default_display_length to be NULL", >+ up => sub { >+ my ($args) = @_; >+ my ($dbh, $out) = @$args{qw(dbh out)}; >+ $dbh->do(q{ >+ ALTER TABLE tables_settings >+ MODIFY COLUMN default_display_length smallint(6) DEFAULT NULL >+ }); >+ }, >+} >diff --git a/installer/data/mysql/kohastructure.sql b/installer/data/mysql/kohastructure.sql >index 8f5f7b438f..f7ec7186b9 100644 >--- a/installer/data/mysql/kohastructure.sql >+++ b/installer/data/mysql/kohastructure.sql >@@ -5063,7 +5063,7 @@ CREATE TABLE `tables_settings` ( > `module` varchar(255) COLLATE utf8mb4_unicode_ci NOT NULL, > `page` varchar(255) COLLATE utf8mb4_unicode_ci NOT NULL, > `tablename` varchar(255) COLLATE utf8mb4_unicode_ci NOT NULL, >- `default_display_length` smallint(6) NOT NULL DEFAULT 20, >+ `default_display_length` smallint(6) DEFAULT NULL, > `default_sort_order` varchar(255) COLLATE utf8mb4_unicode_ci DEFAULT NULL, > PRIMARY KEY (`module`(191),`page`(191),`tablename`(191)) > ) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_unicode_ci; >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 29648
:
128592
|
128593
|
128594
|
128595
|
128596
|
128597
|
128598
|
128599
|
128600
|
128601
|
128602
|
128603
|
128604
|
128605
|
128606
|
128607
|
128608
|
128609
|
128610
|
128611
|
128612
|
128613
|
128614
|
128615
|
128616
|
128617
|
128618
|
128619
|
128620
|
128621
|
128622
|
128623
|
128624
|
128625
|
128626
|
129084
|
129085
|
129089
|
129352
|
129685
|
129686
|
129770
|
129771
|
129772
|
129773
|
129774
|
129775
|
129776
|
129777
|
129778
|
129779
|
129780
|
129781
|
129782
|
129783
|
129784
|
129785
|
129786
|
129787
|
129788
|
129789
|
129790
|
129791
|
129792
|
129793
|
129794
|
129795
|
129796
|
129797
|
129798
|
129799
|
129800
|
129801
|
129802
|
129803
|
129804
|
129805
|
129806
|
131703
|
131875
|
131876
|
133001
|
133002
|
133003
|
133004
|
133005
|
133006
|
133007
|
133008
|
133009
|
133010
|
133011
|
133012
|
133013
|
133014
|
133015
|
133016
|
133017
|
133018
|
133019
|
133020
|
133021
|
133022
|
133023
|
133024
|
133025
|
133026
|
133027
|
134018
|
134019
|
134020
|
134021
|
134022
|
134023
|
134024
|
134025
|
134026
|
134027
|
134028
|
134029
|
134030
|
134031
|
134032
|
134033
|
134034
|
134035
|
134036
|
134037
|
134038
|
134039
|
134040
|
134041
|
134042
|
134043
|
134044
|
134045
|
134046
|
134047
|
134048
|
134049
|
134050
|
134051
|
134052
|
134053
|
134054
|
134086
|
134087
|
134088
|
134089
|
134090
|
134091
|
134092
|
134093
|
134094
|
134095
|
134096
|
134097
|
134098
|
134099
|
134100
|
134101
|
134102
|
134103
|
134104
|
134105
|
134106
|
134107
|
134108
|
134109
|
134110
|
134111
|
134112
|
134113
|
134114
|
134115
|
134116
|
134117
|
134118
|
134119
|
134120
|
134121
|
134122
|
134123
|
134133
|
134134
|
134135
|
134136
|
134137
|
134138
|
134139
|
134140
|
134141
|
134142
|
134143
|
134144
|
134145
|
134146
|
134147
|
134148
|
134149
|
134150
|
134151
|
134152
|
134153
|
134154
|
134155
|
134156
|
134157
|
134158
|
134159
|
134160
|
134161
|
134162
|
134163
|
134164
|
134165
|
134166
|
134167
|
134168
|
134169
|
134170
|
134171
|
134194